From: tip-bot for Stephane Eranian <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, eranian@google.com, hpa@zytor.com,
mingo@kernel.org, peterz@infradead.org, tglx@linutronix.de
Subject: [tip:perf/core] perf/x86/uncore: add hrtimer to SNB uncore IMC PMU
Date: Fri, 21 Feb 2014 13:13:47 -0800 [thread overview]
Message-ID: <tip-ced2efb099f4f24ea7030c22b064e5ddd65cd764@git.kernel.org> (raw)
In-Reply-To: <1392132015-14521-8-git-send-email-eranian@google.com>
Commit-ID: ced2efb099f4f24ea7030c22b064e5ddd65cd764
Gitweb: http://git.kernel.org/tip/ced2efb099f4f24ea7030c22b064e5ddd65cd764
Author: Stephane Eranian <eranian@google.com>
AuthorDate: Tue, 11 Feb 2014 16:20:13 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 21 Feb 2014 21:49:08 +0100
perf/x86/uncore: add hrtimer to SNB uncore IMC PMU
This patch is needed because that PMU uses 32-bit free
running counters with no interrupt capabilities.
On SNB/IVB/HSW, we used 20GB/s theoretical peak to calculate
the hrtimer timeout necessary to avoid missing an overflow.
That delay is set to 5s to be on the cautious side.
The SNB IMC uses free running counters, which are handled
via pseudo fixed counters. The SNB IMC PMU implementation
supports an arbitrary number of events, because the counters
are read-only. Therefore it is not possible to track active
counters. Instead we put active events on a linked list which
is then used by the hrtimer handler to update the SW counts.
Cc: mingo@elte.hu
Cc: acme@redhat.com
Cc: ak@linux.intel.com
Cc: zheng.z.yan@intel.com
Cc: peterz@infradead.org
Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1392132015-14521-8-git-send-email-eranian@google.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/cpu/perf_event_intel_uncore.c | 12 ++++++++++++
arch/x86/kernel/cpu/perf_event_intel_uncore.h | 2 ++
2 files changed, 14 insertions(+)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
index 66ce5e5..7760aee 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
@@ -1728,6 +1728,7 @@ static void snb_uncore_imc_init_box(struct intel_uncore_box *box)
addr &= ~(PAGE_SIZE - 1);
box->io_addr = ioremap(addr, SNB_UNCORE_PCI_IMC_MAP_SIZE);
+ box->hrtimer_duration = UNCORE_SNB_IMC_HRTIMER_INTERVAL;
}
static void snb_uncore_imc_enable_box(struct intel_uncore_box *box)
@@ -3160,6 +3161,7 @@ again:
static enum hrtimer_restart uncore_pmu_hrtimer(struct hrtimer *hrtimer)
{
struct intel_uncore_box *box;
+ struct perf_event *event;
unsigned long flags;
int bit;
@@ -3172,6 +3174,14 @@ static enum hrtimer_restart uncore_pmu_hrtimer(struct hrtimer *hrtimer)
*/
local_irq_save(flags);
+ /*
+ * handle boxes with an active event list as opposed to active
+ * counters
+ */
+ list_for_each_entry(event, &box->active_list, active_entry) {
+ uncore_perf_event_update(box, event);
+ }
+
for_each_set_bit(bit, box->active_mask, UNCORE_PMC_IDX_MAX)
uncore_perf_event_update(box, box->events[bit]);
@@ -3221,6 +3231,8 @@ static struct intel_uncore_box *uncore_alloc_box(struct intel_uncore_type *type,
/* set default hrtimer timeout */
box->hrtimer_duration = UNCORE_PMU_HRTIMER_INTERVAL;
+ INIT_LIST_HEAD(&box->active_list);
+
return box;
}
diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.h b/arch/x86/kernel/cpu/perf_event_intel_uncore.h
index fbf45a0..90236f0 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.h
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.h
@@ -6,6 +6,7 @@
#define UNCORE_PMU_NAME_LEN 32
#define UNCORE_PMU_HRTIMER_INTERVAL (60LL * NSEC_PER_SEC)
+#define UNCORE_SNB_IMC_HRTIMER_INTERVAL (5ULL * NSEC_PER_SEC)
#define UNCORE_FIXED_EVENT 0xff
#define UNCORE_PMC_IDX_MAX_GENERIC 8
@@ -492,6 +493,7 @@ struct intel_uncore_box {
u64 hrtimer_duration; /* hrtimer timeout for this box */
struct hrtimer hrtimer;
struct list_head list;
+ struct list_head active_list;
void *io_addr;
struct intel_uncore_extra_reg shared_regs[0];
};
next prev parent reply other threads:[~2014-02-21 21:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 15:20 [PATCH v2 0/8] perf/x86/uncore: add support for SNB/IVB/HSW integrated memory controller PMU Stephane Eranian
2014-02-11 15:20 ` [PATCH v2 1/8] perf/x86/uncore: fix initialization of cpumask Stephane Eranian
2014-02-21 21:12 ` [tip:perf/core] " tip-bot for Stephane Eranian
2014-02-11 15:20 ` [PATCH v2 2/8] perf/x86/uncore: add ability to customize pmu callbacks Stephane Eranian
2014-02-21 21:12 ` [tip:perf/core] " tip-bot for Stephane Eranian
2014-02-11 15:20 ` [PATCH v2 3/8] perf/x86/uncore: add PCI ids for SNB/IVB/HSW IMC Stephane Eranian
2014-02-21 21:13 ` [tip:perf/core] " tip-bot for Stephane Eranian
2014-02-11 15:20 ` [PATCH v2 4/8] perf/x86/uncore: make hrtimer timeout configurable per box Stephane Eranian
2014-02-21 21:13 ` [tip:perf/core] " tip-bot for Stephane Eranian
2014-02-11 15:20 ` [PATCH v2 5/8] perf/x86/uncore: move uncore_event_to_box() and uncore_pmu_to_box() Stephane Eranian
2014-02-21 21:13 ` [tip:perf/core] " tip-bot for Stephane Eranian
2014-02-11 15:20 ` [PATCH v2 6/8] perf/x86/uncore: add SNB/IVB/HSW client uncore memory controller support Stephane Eranian
2014-02-11 16:19 ` Peter Zijlstra
2014-02-11 16:25 ` Stephane Eranian
2014-02-11 16:50 ` Peter Zijlstra
2014-02-11 18:31 ` Stephane Eranian
2014-02-11 20:34 ` Peter Zijlstra
2014-02-21 21:13 ` [tip:perf/core] perf/x86/uncore: add SNB/IVB/ HSW " tip-bot for Stephane Eranian
2014-02-11 15:20 ` [PATCH v2 7/8] perf/x86/uncore: add hrtimer to SNB uncore IMC PMU Stephane Eranian
2014-02-21 21:13 ` tip-bot for Stephane Eranian [this message]
2014-02-11 15:20 ` [PATCH v2 8/8] perf/x86/uncore: use MiB unit for events for SNB/IVB/HSW IMC Stephane Eranian
2014-02-21 21:13 ` [tip:perf/core] perf/x86/uncore: use MiB unit for events for SNB/ IVB/HSW IMC tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ced2efb099f4f24ea7030c22b064e5ddd65cd764@git.kernel.org \
--to=tipbot@zytor.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox