* [PATCH] sched, __wake_up_sync_key: Fix nr_exclusive tasks which lead to WF_SYNC clearing
@ 2013-07-04 18:48 Kirill Tkhai
2013-07-05 10:28 ` Peter Zijlstra
2013-07-12 13:29 ` [tip:sched/core] sched/__wake_up_sync_key(): " tip-bot for Kirill Tkhai
0 siblings, 2 replies; 3+ messages in thread
From: Kirill Tkhai @ 2013-07-04 18:48 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org; +Cc: Steven Rostedt, Peter Zijlstra, Ingo Molnar
The only one task can replace waker.
Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Ingo Molnar <mingo@redhat.com>
CC: Peter Zijlstra <peterz@infradead.org>
---
kernel/sched/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 9d06ad6..4ff7404 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2658,7 +2658,7 @@ void __wake_up_sync_key(wait_queue_head_t *q, unsigned int mode,
if (unlikely(!q))
return;
- if (unlikely(!nr_exclusive))
+ if (unlikely(nr_exclusive != 1))
wake_flags = 0;
spin_lock_irqsave(&q->lock, flags);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sched, __wake_up_sync_key: Fix nr_exclusive tasks which lead to WF_SYNC clearing
2013-07-04 18:48 [PATCH] sched, __wake_up_sync_key: Fix nr_exclusive tasks which lead to WF_SYNC clearing Kirill Tkhai
@ 2013-07-05 10:28 ` Peter Zijlstra
2013-07-12 13:29 ` [tip:sched/core] sched/__wake_up_sync_key(): " tip-bot for Kirill Tkhai
1 sibling, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2013-07-05 10:28 UTC (permalink / raw)
To: Kirill Tkhai; +Cc: linux-kernel@vger.kernel.org, Steven Rostedt, Ingo Molnar
On Thu, Jul 04, 2013 at 10:48:20PM +0400, Kirill Tkhai wrote:
> The only one task can replace waker.
Fair enough.. thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:sched/core] sched/__wake_up_sync_key(): Fix nr_exclusive tasks which lead to WF_SYNC clearing
2013-07-04 18:48 [PATCH] sched, __wake_up_sync_key: Fix nr_exclusive tasks which lead to WF_SYNC clearing Kirill Tkhai
2013-07-05 10:28 ` Peter Zijlstra
@ 2013-07-12 13:29 ` tip-bot for Kirill Tkhai
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Kirill Tkhai @ 2013-07-12 13:29 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, rostedt, peterz, tkhai, tglx
Commit-ID: cedce3e730833d26a37826a96e1905b6ef387df9
Gitweb: http://git.kernel.org/tip/cedce3e730833d26a37826a96e1905b6ef387df9
Author: Kirill Tkhai <tkhai@yandex.ru>
AuthorDate: Thu, 4 Jul 2013 22:48:20 +0400
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 12 Jul 2013 13:54:03 +0200
sched/__wake_up_sync_key(): Fix nr_exclusive tasks which lead to WF_SYNC clearing
Only one task can replace the waker.
Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
CC: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/512421372963700@web25f.yandex.ru
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 0d8eb45..f737871 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2660,7 +2660,7 @@ void __wake_up_sync_key(wait_queue_head_t *q, unsigned int mode,
if (unlikely(!q))
return;
- if (unlikely(!nr_exclusive))
+ if (unlikely(nr_exclusive != 1))
wake_flags = 0;
spin_lock_irqsave(&q->lock, flags);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-12 13:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-04 18:48 [PATCH] sched, __wake_up_sync_key: Fix nr_exclusive tasks which lead to WF_SYNC clearing Kirill Tkhai
2013-07-05 10:28 ` Peter Zijlstra
2013-07-12 13:29 ` [tip:sched/core] sched/__wake_up_sync_key(): " tip-bot for Kirill Tkhai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox