* [PATCH] x86, mm: Fix section mismatch in tlb.c
@ 2010-11-01 6:53 Rakib Mullick
2010-11-01 9:13 ` [tip:x86/urgent] " tip-bot for Rakib Mullick
0 siblings, 1 reply; 2+ messages in thread
From: Rakib Mullick @ 2010-11-01 6:53 UTC (permalink / raw)
To: Ingo Molnar, H. Peter Anvin, Thomas Gleixner
Cc: LKML, x86, Borislav Petkov, Shaohua Li
Mark tlb_cpuhp_notify as __cpuinit. It's basically a callback
function, which is called from __cpuinit init_smp_flash(). So - it's
safe.
We were warned by the following warning:
WARNING: arch/x86/mm/built-in.o(.text+0x356d): Section mismatch in
reference from the function tlb_cpuhp_notify() to the function
.cpuinit.text:calculate_tlb_offset()
The function tlb_cpuhp_notify() references
the function __cpuinit calculate_tlb_offset().
This is often because tlb_cpuhp_notify lacks a __cpuinit
annotation or the annotation of calculate_tlb_offset is wrong.
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
---
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 4935848..12cdbb1 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -251,7 +251,7 @@ static void __cpuinit calculate_tlb_offset(void)
}
}
-static int tlb_cpuhp_notify(struct notifier_block *n,
+static int __cpuinit tlb_cpuhp_notify(struct notifier_block *n,
unsigned long action, void *hcpu)
{
switch (action & 0xf) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/urgent] x86, mm: Fix section mismatch in tlb.c
2010-11-01 6:53 [PATCH] x86, mm: Fix section mismatch in tlb.c Rakib Mullick
@ 2010-11-01 9:13 ` tip-bot for Rakib Mullick
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Rakib Mullick @ 2010-11-01 9:13 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, rakib.mullick, shaohua.li, tglx,
borislav.petkov, mingo
Commit-ID: cf38d0ba7efdc476815768b2b999b27cfae69747
Gitweb: http://git.kernel.org/tip/cf38d0ba7efdc476815768b2b999b27cfae69747
Author: Rakib Mullick <rakib.mullick@gmail.com>
AuthorDate: Mon, 1 Nov 2010 12:53:50 +0600
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 1 Nov 2010 10:09:07 +0100
x86, mm: Fix section mismatch in tlb.c
Mark tlb_cpuhp_notify as __cpuinit. It's basically a callback
function, which is called from __cpuinit init_smp_flash(). So -
it's safe.
We were warned by the following warning:
WARNING: arch/x86/mm/built-in.o(.text+0x356d): Section mismatch
in reference from the function tlb_cpuhp_notify() to the
function .cpuinit.text:calculate_tlb_offset()
The function tlb_cpuhp_notify() references
the function __cpuinit calculate_tlb_offset().
This is often because tlb_cpuhp_notify lacks a __cpuinit
annotation or the annotation of calculate_tlb_offset is wrong.
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Borislav Petkov <borislav.petkov@amd.com>
Cc: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <AANLkTinWQRG=HA9uB3ad0KAqRRTinL6L_4iKgF84coph@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/mm/tlb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 4935848..12cdbb1 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -251,7 +251,7 @@ static void __cpuinit calculate_tlb_offset(void)
}
}
-static int tlb_cpuhp_notify(struct notifier_block *n,
+static int __cpuinit tlb_cpuhp_notify(struct notifier_block *n,
unsigned long action, void *hcpu)
{
switch (action & 0xf) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-01 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-01 6:53 [PATCH] x86, mm: Fix section mismatch in tlb.c Rakib Mullick
2010-11-01 9:13 ` [tip:x86/urgent] " tip-bot for Rakib Mullick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox