public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Rado Vrbovsky <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	rvrbovsk@redhat.com, tglx@linutronix.de, dzickus@redhat.com
Subject: [tip:timers/core] tick: Change log level of NOHZ: local_softirq_pending message
Date: Mon, 25 Mar 2013 02:58:51 -0700	[thread overview]
Message-ID: <tip-cfea7d7e452f57682a0bb55a55e9f79c569558c2@git.kernel.org> (raw)
In-Reply-To: <2037057938.893524.1360345050772.JavaMail.root@redhat.com>

Commit-ID:  cfea7d7e452f57682a0bb55a55e9f79c569558c2
Gitweb:     http://git.kernel.org/tip/cfea7d7e452f57682a0bb55a55e9f79c569558c2
Author:     Rado Vrbovsky <rvrbovsk@redhat.com>
AuthorDate: Fri, 8 Feb 2013 12:37:30 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 25 Mar 2013 10:46:59 +0100

tick: Change log level of NOHZ: local_softirq_pending message

The "NOHZ: local_softirq_pending" message is a largely informational
message.  This makes extra work for customers that have a policy of
investigating all kernel log messages logged at <= KERN_ERR log level.
This patch sets the message to a different log level.

[ tglx: Use pr_warn() ]

Signed-off-by: Rado Vrbovsky <rvrbovsk@redhat.com>
Cc: Don Zickus <dzickus@redhat.com>
Link: http://lkml.kernel.org/r/2037057938.893524.1360345050772.JavaMail.root@redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 kernel/time/tick-sched.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index a19a399..225f8bf 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -482,8 +482,8 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
 
 		if (ratelimit < 10 &&
 		    (local_softirq_pending() & SOFTIRQ_STOP_IDLE_MASK)) {
-			printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
-			       (unsigned int) local_softirq_pending());
+			pr_warn("NOHZ: local_softirq_pending %02x\n",
+				(unsigned int) local_softirq_pending());
 			ratelimit++;
 		}
 		return false;

      reply	other threads:[~2013-03-25 10:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <350315726.726339.1360327201303.JavaMail.root@redhat.com>
2013-02-08 17:37 ` [PATCH] time: Change log level of "NOHZ: local_softirq_pending" message Rado Vrbovsky
2013-03-25  9:58   ` tip-bot for Rado Vrbovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-cfea7d7e452f57682a0bb55a55e9f79c569558c2@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=dzickus@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rvrbovsk@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox