From: tip-bot for Matthias Kaehlcke <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: akpm@linux-foundation.org, rusty@rustcorp.com.au,
tglx@linutronix.de, mka@chromium.org, grundler@chromium.org,
hpa@zytor.com, md@google.com, mingo@kernel.org,
linux-kernel@vger.kernel.org, ghackmann@google.com
Subject: [tip:irq/core] genirq: Use cpumask_available() for check of cpumask variable
Date: Fri, 14 Apr 2017 11:51:56 -0700 [thread overview]
Message-ID: <tip-d170fe7dd992b313d4851ae5ab77ee7a51ed8c72@git.kernel.org> (raw)
In-Reply-To: <20170412182030.83657-2-mka@chromium.org>
Commit-ID: d170fe7dd992b313d4851ae5ab77ee7a51ed8c72
Gitweb: http://git.kernel.org/tip/d170fe7dd992b313d4851ae5ab77ee7a51ed8c72
Author: Matthias Kaehlcke <mka@chromium.org>
AuthorDate: Wed, 12 Apr 2017 11:20:30 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 14 Apr 2017 20:49:27 +0200
genirq: Use cpumask_available() for check of cpumask variable
This fixes the following clang warning when CONFIG_CPUMASK_OFFSTACK=n:
kernel/irq/manage.c:839:28: error: address of array
'desc->irq_common_data.affinity' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Cc: Grant Grundler <grundler@chromium.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Greg Hackmann <ghackmann@google.com>
Cc: Michael Davidson <md@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20170412182030.83657-2-mka@chromium.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/irq/manage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index a4afe5c..155e3c3 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -852,7 +852,7 @@ irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action)
* This code is triggered unconditionally. Check the affinity
* mask pointer. For CPU_MASK_OFFSTACK=n this is optimized out.
*/
- if (desc->irq_common_data.affinity)
+ if (cpumask_available(desc->irq_common_data.affinity))
cpumask_copy(mask, desc->irq_common_data.affinity);
else
valid = false;
next prev parent reply other threads:[~2017-04-14 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 18:20 [PATCH v2 1/2] cpumask: Add helper cpumask_available() Matthias Kaehlcke
2017-04-12 18:20 ` [PATCH v2 2/2] kernel/irq: Use cpumask_available() for check of cpumask variable Matthias Kaehlcke
2017-04-14 17:51 ` Thomas Gleixner
2017-04-14 17:55 ` [tip:irq/core] " tip-bot for Matthias Kaehlcke
2017-04-14 18:51 ` tip-bot for Matthias Kaehlcke [this message]
2017-04-14 17:54 ` [tip:irq/core] cpumask: Add helper cpumask_available() tip-bot for Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-d170fe7dd992b313d4851ae5ab77ee7a51ed8c72@git.kernel.org \
--to=tipbot@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=ghackmann@google.com \
--cc=grundler@chromium.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=md@google.com \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox