public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [tip:x86/urgent] arch/x86/platform/geode/net5501.c: change active_low to 0 for LED driver
       [not found] <20120504210146.62186A018B@akpm.mtv.corp.google.com>
@ 2012-05-05 18:45 ` tip-bot for Bjarke Istrup Pedersen
  0 siblings, 0 replies; only message in thread
From: tip-bot for Bjarke Istrup Pedersen @ 2012-05-05 18:45 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, akpm, philipp, gurligebis, tglx

Commit-ID:  d1d0589a565a2528a044cfd680141c3e2db18d0a
Gitweb:     http://git.kernel.org/tip/d1d0589a565a2528a044cfd680141c3e2db18d0a
Author:     Bjarke Istrup Pedersen <gurligebis@gentoo.org>
AuthorDate: Fri, 4 May 2012 14:01:45 -0700
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Fri, 4 May 2012 14:40:07 -0700

arch/x86/platform/geode/net5501.c: change active_low to 0 for LED driver

It seems that there was an error with the active_low = 1 for the
LED, since it should be set to 0 (meaning that active is high,
since 0 is false, hence the confusion.

The wiki article about it confuses it, since it contradicts itself,
regarding what turns on the LED.

I have tested 3.4-rc2 on my net5501 with this patch, and it makes the LED
behave correctly, where "none" turns it off, and "default-on" turns it on,
when echoed onto the trigger "file" in /sys/class/leds.

Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
Link: http://lkml.kernel.org/r/20120504210146.62186A018B@akpm.mtv.corp.google.com
Cc: Philip Prindeville <philipp@redfish-solutions.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/platform/geode/net5501.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
index 66d377e..646e3b5 100644
--- a/arch/x86/platform/geode/net5501.c
+++ b/arch/x86/platform/geode/net5501.c
@@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
 		.name = "net5501:1",
 		.gpio = 6,
 		.default_trigger = "default-on",
-		.active_low = 1,
+		.active_low = 0,
 	},
 };
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-05-05 18:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20120504210146.62186A018B@akpm.mtv.corp.google.com>
2012-05-05 18:45 ` [tip:x86/urgent] arch/x86/platform/geode/net5501.c: change active_low to 0 for LED driver tip-bot for Bjarke Istrup Pedersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox