From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759953AbcBYFww (ORCPT ); Thu, 25 Feb 2016 00:52:52 -0500 Received: from torg.zytor.com ([198.137.202.12]:54186 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759905AbcBYFwg (ORCPT ); Thu, 25 Feb 2016 00:52:36 -0500 Date: Wed, 24 Feb 2016 21:51:12 -0800 From: tip-bot for Josh Poimboeuf Message-ID: Cc: dvlasenk@redhat.com, bp@alien8.de, akpm@linux-foundation.org, acme@kernel.org, peterz@infradead.org, bernd@petrovitsch.priv.at, mmarek@suse.cz, chris.j.arges@canonical.com, torvalds@linux-foundation.org, mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, namhyung@gmail.com, hpa@zytor.com, luto@amacapital.net, luto@kernel.org, jslaby@suse.cz, brgerst@gmail.com, jpoimboe@redhat.com, palves@redhat.com, ast@kernel.org Reply-To: mmarek@suse.cz, bernd@petrovitsch.priv.at, torvalds@linux-foundation.org, chris.j.arges@canonical.com, peterz@infradead.org, acme@kernel.org, bp@alien8.de, akpm@linux-foundation.org, dvlasenk@redhat.com, namhyung@gmail.com, linux-kernel@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de, jslaby@suse.cz, luto@kernel.org, hpa@zytor.com, luto@amacapital.net, jpoimboe@redhat.com, palves@redhat.com, ast@kernel.org, brgerst@gmail.com In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/debug] x86/asm/bpf: Create stack frames in bpf_jit.S Git-Commit-ID: d21001cc15ba9f63b0334d60942278587471a451 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: d21001cc15ba9f63b0334d60942278587471a451 Gitweb: http://git.kernel.org/tip/d21001cc15ba9f63b0334d60942278587471a451 Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:27 -0600 Committer: Ingo Molnar CommitDate: Wed, 24 Feb 2016 08:35:44 +0100 x86/asm/bpf: Create stack frames in bpf_jit.S bpf_jit.S has several callable non-leaf functions which don't honor CONFIG_FRAME_POINTER, which can result in bad stack traces. Create a stack frame before the call instructions when CONFIG_FRAME_POINTER is enabled. Signed-off-by: Josh Poimboeuf Acked-by: Alexei Starovoitov Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: live-patching@vger.kernel.org Cc: netdev@vger.kernel.org Link: http://lkml.kernel.org/r/fa4c41976b438b51954cb8021f06bceb1d1d66cc.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/net/bpf_jit.S | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/x86/net/bpf_jit.S b/arch/x86/net/bpf_jit.S index eb4a3bd..f2a7faf 100644 --- a/arch/x86/net/bpf_jit.S +++ b/arch/x86/net/bpf_jit.S @@ -8,6 +8,7 @@ * of the License. */ #include +#include /* * Calling convention : @@ -65,16 +66,18 @@ FUNC(sk_load_byte_positive_offset) /* rsi contains offset and can be scratched */ #define bpf_slow_path_common(LEN) \ + lea -MAX_BPF_STACK + 32(%rbp), %rdx;\ + FRAME_BEGIN; \ mov %rbx, %rdi; /* arg1 == skb */ \ push %r9; \ push SKBDATA; \ /* rsi already has offset */ \ mov $LEN,%ecx; /* len */ \ - lea - MAX_BPF_STACK + 32(%rbp),%rdx; \ call skb_copy_bits; \ test %eax,%eax; \ pop SKBDATA; \ - pop %r9; + pop %r9; \ + FRAME_END bpf_slow_path_word: @@ -99,6 +102,7 @@ bpf_slow_path_byte: ret #define sk_negative_common(SIZE) \ + FRAME_BEGIN; \ mov %rbx, %rdi; /* arg1 == skb */ \ push %r9; \ push SKBDATA; \ @@ -108,6 +112,7 @@ bpf_slow_path_byte: test %rax,%rax; \ pop SKBDATA; \ pop %r9; \ + FRAME_END; \ jz bpf_error bpf_slow_path_word_neg: