linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Fenghua Yu <fenghua.yu@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	fenghua.yu@intel.com, tglx@linutronix.de, hpa@linux.intel.com
Subject: [tip:x86/microcode] x86/common.c: Make have_cpuid_p() a global function
Date: Thu, 31 Jan 2013 14:27:28 -0800	[thread overview]
Message-ID: <tip-d288e1cf8e62f3e4034f1f021f047009c4ac0b3c@git.kernel.org> (raw)
In-Reply-To: <1356075872-3054-4-git-send-email-fenghua.yu@intel.com>

Commit-ID:  d288e1cf8e62f3e4034f1f021f047009c4ac0b3c
Gitweb:     http://git.kernel.org/tip/d288e1cf8e62f3e4034f1f021f047009c4ac0b3c
Author:     Fenghua Yu <fenghua.yu@intel.com>
AuthorDate: Thu, 20 Dec 2012 23:44:23 -0800
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Thu, 31 Jan 2013 13:18:58 -0800

x86/common.c: Make have_cpuid_p() a global function

Remove static declaration in have_cpuid_p() to make it a global function. The
function will be called in early loading microcode.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Link: http://lkml.kernel.org/r/1356075872-3054-4-git-send-email-fenghua.yu@intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/include/asm/processor.h | 8 ++++++++
 arch/x86/kernel/cpu/common.c     | 9 +++------
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index bdee8bd..3cdf4aa 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -190,6 +190,14 @@ extern void init_amd_cacheinfo(struct cpuinfo_x86 *c);
 extern void detect_extended_topology(struct cpuinfo_x86 *c);
 extern void detect_ht(struct cpuinfo_x86 *c);
 
+#ifdef CONFIG_X86_32
+extern int have_cpuid_p(void);
+#else
+static inline int have_cpuid_p(void)
+{
+	return 1;
+}
+#endif
 static inline void native_cpuid(unsigned int *eax, unsigned int *ebx,
 				unsigned int *ecx, unsigned int *edx)
 {
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 9c3ab43..d7fd246 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -37,6 +37,8 @@
 #include <asm/mce.h>
 #include <asm/msr.h>
 #include <asm/pat.h>
+#include <asm/microcode.h>
+#include <asm/microcode_intel.h>
 
 #ifdef CONFIG_X86_LOCAL_APIC
 #include <asm/uv/uv.h>
@@ -213,7 +215,7 @@ static inline int flag_is_changeable_p(u32 flag)
 }
 
 /* Probe for the CPUID instruction */
-static int __cpuinit have_cpuid_p(void)
+int __cpuinit have_cpuid_p(void)
 {
 	return flag_is_changeable_p(X86_EFLAGS_ID);
 }
@@ -249,11 +251,6 @@ static inline int flag_is_changeable_p(u32 flag)
 {
 	return 1;
 }
-/* Probe for the CPUID instruction */
-static inline int have_cpuid_p(void)
-{
-	return 1;
-}
 static inline void squash_the_stupid_serial_number(struct cpuinfo_x86 *c)
 {
 }

  reply	other threads:[~2013-01-31 22:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-21  7:44 [PATCH v5 00/12] x86/microcode: Early load microcode Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 01/12] Documentation/x86: " Fenghua Yu
2013-01-31 22:25   ` [tip:x86/microcode] x86, doc: Documentation for early microcode loading tip-bot for Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 02/12] x86/microcode_intel.h: Define functions and macros for early loading ucode Fenghua Yu
2013-01-31 22:26   ` [tip:x86/microcode] " tip-bot for Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 03/12] x86/common.c: Make have_cpuid_p() a global function Fenghua Yu
2013-01-31 22:27   ` tip-bot for Fenghua Yu [this message]
2012-12-21  7:44 ` [PATCH v5 04/12] x86/common.c: load ucode in 64 bit or show loading ucode info in 32 bit on AP Fenghua Yu
2013-01-31 22:28   ` [tip:x86/microcode] " tip-bot for Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 05/12] x86/microcode_core_early.c: Define interfaces for early loading ucode Fenghua Yu
2013-01-31 22:29   ` [tip:x86/microcode] " tip-bot for Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 06/12] x86/microcode_intel_lib.c: Early update ucode on Intel's CPU Fenghua Yu
2013-01-31 22:31   ` [tip:x86/microcode] " tip-bot for Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 07/12] x86/tlbflush.h: Define __native_flush_tlb_global_irq_disabled() Fenghua Yu
2013-01-31 22:32   ` [tip:x86/microcode] " tip-bot for Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 08/12] x86/microcode_intel_early.c: Early update ucode on Intel's CPU Fenghua Yu
2013-01-31 22:33   ` [tip:x86/microcode] " tip-bot for Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 09/12] x86/head_32.S: Early update ucode in 32-bit Fenghua Yu
2013-01-31 22:34   ` [tip:x86/microcode] " tip-bot for Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 10/12] x86/head64.c: Early update ucode in 64-bit Fenghua Yu
2013-01-31 22:35   ` [tip:x86/microcode] " tip-bot for Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 11/12] x86/mm/init.c: Copy ucode from initrd image to kernel memory Fenghua Yu
2013-01-31 22:37   ` [tip:x86/microcode] " tip-bot for Fenghua Yu
2012-12-21  7:44 ` [PATCH v5 12/12] x86/Kconfig: Configurations to enable/disable the feature Fenghua Yu
2013-01-31 22:38   ` [tip:x86/microcode] x86/Kconfig: Make early microcode loading a configuration feature tip-bot for Fenghua Yu
2013-01-03 17:44 ` [PATCH v5 00/12] x86/microcode: Early load microcode Konrad Rzeszutek Wilk
2013-01-03 17:48   ` H. Peter Anvin
2013-01-08 19:46     ` Konrad Rzeszutek Wilk
2013-01-08 19:47       ` H. Peter Anvin
2013-01-08 20:04         ` Konrad Rzeszutek Wilk
2013-01-08 20:16           ` H. Peter Anvin
2013-01-09 13:35           ` Konrad Rzeszutek Wilk
2023-10-09 12:29 ` [tip: x86/microcode] x86/microcode/32: Move early loading after paging enable tip-bot2 for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-d288e1cf8e62f3e4034f1f021f047009c4ac0b3c@git.kernel.org \
    --to=fenghua.yu@intel.com \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).