From: tip-bot for Len Brown <len.brown@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
venkatesh.pallipadi@intel.com, tglx@linutronix.de, mingo@elte.hu,
len.brown@intel.com
Subject: [tip:x86/urgent] x86, hpet: Stop soliciting hpet=force users on ICH4M
Date: Fri, 24 Apr 2009 06:45:58 GMT [thread overview]
Message-ID: <tip-d2c8604121648b744ebb127991f1c5876931885e@git.kernel.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0904231918510.15843@localhost.localdomain>
Commit-ID: d2c8604121648b744ebb127991f1c5876931885e
Gitweb: http://git.kernel.org/tip/d2c8604121648b744ebb127991f1c5876931885e
Author: Len Brown <len.brown@intel.com>
AuthorDate: Thu, 23 Apr 2009 19:19:42 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 24 Apr 2009 08:41:39 +0200
x86, hpet: Stop soliciting hpet=force users on ICH4M
The HPET in the ICH4M is not documented in the data sheet
because it was not officially validated.
While it is fine for hackers to continue to use "hpet=force"
to enable the hardware that they have, it is not prudent to
solicit additional "hpet=force" users on this hardware.
[ Impact: remove hpet=force syslog message on old-ICH systems ]
Signed-off-by: Len Brown <len.brown@intel.com>
Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
LKML-Reference: <alpine.LFD.2.00.0904231918510.15843@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/quirks.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
index e95022e..7563b31 100644
--- a/arch/x86/kernel/quirks.c
+++ b/arch/x86/kernel/quirks.c
@@ -261,8 +261,6 @@ static void old_ich_force_enable_hpet_user(struct pci_dev *dev)
{
if (hpet_force_user)
old_ich_force_enable_hpet(dev);
- else
- hpet_print_force_info();
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB_1,
next prev parent reply other threads:[~2009-04-24 6:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 2:27 [PATCH] x86/hpet: prevent boot hang when hpet=force used on old ICH Len Brown
2009-04-23 6:09 ` Ingo Molnar
2009-04-23 23:05 ` Len Brown
2009-04-24 23:45 ` Ingo Molnar
2009-04-23 23:18 ` [PATCH] ACPI/hpet: prevent boot hang when hpet=force used on ICH-4M Len Brown
2009-04-23 23:18 ` Pallipadi, Venkatesh
2009-04-23 23:19 ` [PATCH] HPET: stop soliciting hpet=force users on ICH4M Len Brown
2009-04-23 23:19 ` Pallipadi, Venkatesh
2009-04-24 6:43 ` Ingo Molnar
2009-04-24 6:45 ` tip-bot for Len Brown [this message]
2009-04-24 6:37 ` [PATCH] ACPI/hpet: prevent boot hang when hpet=force used on ICH-4M Ingo Molnar
2009-04-24 14:49 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-d2c8604121648b744ebb127991f1c5876931885e@git.kernel.org \
--to=len.brown@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox