public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] lockdep: remove unnecessary unlikely()
@ 2019-04-29 12:26 zhengbin
  2019-04-29 14:16 ` [tip:locking/core] locking/lockdep: Remove " tip-bot for zhengbin
  0 siblings, 1 reply; 2+ messages in thread
From: zhengbin @ 2019-04-29 12:26 UTC (permalink / raw)
  To: peterz, mingo, will.deacon, linux-kernel; +Cc: houtao1

DEBUG_LOCKS_WARN_ON() already contains an unlikely(), there is no need
for another one.

Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 kernel/locking/lockdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index e221be7..1522034 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -3157,7 +3157,7 @@ void lockdep_hardirqs_on(unsigned long ip)
 	/*
 	 * See the fine text that goes along with this variable definition.
 	 */
-	if (DEBUG_LOCKS_WARN_ON(unlikely(early_boot_irqs_disabled)))
+	if (DEBUG_LOCKS_WARN_ON(early_boot_irqs_disabled))
 		return;

 	/*
--
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:locking/core] locking/lockdep: Remove unnecessary unlikely()
  2019-04-29 12:26 [PATCH] lockdep: remove unnecessary unlikely() zhengbin
@ 2019-04-29 14:16 ` tip-bot for zhengbin
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for zhengbin @ 2019-04-29 14:16 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: peterz, torvalds, tglx, linux-kernel, paulmck, akpm, mingo,
	will.deacon, hpa, zhengbin13

Commit-ID:  d671002be6bdd7f77a771e23bf3e95d1f16775e6
Gitweb:     https://git.kernel.org/tip/d671002be6bdd7f77a771e23bf3e95d1f16775e6
Author:     zhengbin <zhengbin13@huawei.com>
AuthorDate: Mon, 29 Apr 2019 20:26:31 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 29 Apr 2019 16:11:01 +0200

locking/lockdep: Remove unnecessary unlikely()

DEBUG_LOCKS_WARN_ON() already contains an unlikely(), there is no need
for another one.

Signed-off-by: zhengbin <zhengbin13@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Deacon <will.deacon@arm.com>
Cc: houtao1@huawei.com
Link: http://lkml.kernel.org/r/1556540791-23110-1-git-send-email-zhengbin13@huawei.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/locking/lockdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 25ecc6d3058b..6426d071a324 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -3256,7 +3256,7 @@ void lockdep_hardirqs_on(unsigned long ip)
 	/*
 	 * See the fine text that goes along with this variable definition.
 	 */
-	if (DEBUG_LOCKS_WARN_ON(unlikely(early_boot_irqs_disabled)))
+	if (DEBUG_LOCKS_WARN_ON(early_boot_irqs_disabled))
 		return;
 
 	/*

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-29 14:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-29 12:26 [PATCH] lockdep: remove unnecessary unlikely() zhengbin
2019-04-29 14:16 ` [tip:locking/core] locking/lockdep: Remove " tip-bot for zhengbin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox