From: tip-bot for Andi Kleen <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
tglx@linutronix.de, mingo@kernel.org, ak@linux.intel.com,
jolsa@kernel.org, hpa@zytor.com
Subject: [tip:perf/core] perf xyarray: Save max_x, max_y
Date: Thu, 24 Aug 2017 01:19:31 -0700 [thread overview]
Message-ID: <tip-d74be47673676eded2f0bb8274e752bed32c42d8@git.kernel.org> (raw)
In-Reply-To: <20170811232634.30465-1-andi@firstfloor.org>
Commit-ID: d74be47673676eded2f0bb8274e752bed32c42d8
Gitweb: http://git.kernel.org/tip/d74be47673676eded2f0bb8274e752bed32c42d8
Author: Andi Kleen <ak@linux.intel.com>
AuthorDate: Fri, 11 Aug 2017 16:26:16 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 22 Aug 2017 11:51:28 -0300
perf xyarray: Save max_x, max_y
Save the original array dimensions in xyarrays, so that users can
retrieve them later. Add some inline functions to access these fields.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20170811232634.30465-1-andi@firstfloor.org
[ As noticed by Jiri, fix up namespacing: xy__method() -> xyarray__method() ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/xyarray.c | 2 ++
tools/perf/util/xyarray.h | 12 ++++++++++++
2 files changed, 14 insertions(+)
diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c
index 7251fdb..c8f415d 100644
--- a/tools/perf/util/xyarray.c
+++ b/tools/perf/util/xyarray.c
@@ -12,6 +12,8 @@ struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size)
xy->entry_size = entry_size;
xy->row_size = row_size;
xy->entries = xlen * ylen;
+ xy->max_x = xlen;
+ xy->max_y = ylen;
}
return xy;
diff --git a/tools/perf/util/xyarray.h b/tools/perf/util/xyarray.h
index 7f30af3..4ba726c 100644
--- a/tools/perf/util/xyarray.h
+++ b/tools/perf/util/xyarray.h
@@ -7,6 +7,8 @@ struct xyarray {
size_t row_size;
size_t entry_size;
size_t entries;
+ size_t max_x;
+ size_t max_y;
char contents[];
};
@@ -19,4 +21,14 @@ static inline void *xyarray__entry(struct xyarray *xy, int x, int y)
return &xy->contents[x * xy->row_size + y * xy->entry_size];
}
+static inline int xyarray__max_y(struct xyarray *xy)
+{
+ return xy->max_x;
+}
+
+static inline int xyarray__max_x(struct xyarray *xy)
+{
+ return xy->max_y;
+}
+
#endif /* _PERF_XYARRAY_H_ */
prev parent reply other threads:[~2017-08-24 8:20 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 23:26 [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Andi Kleen
2017-08-11 23:26 ` [PATCH v2 02/19] perf, tools: Fix buffer overflow while freeing events Andi Kleen
2017-08-22 8:20 ` Jiri Olsa
2017-08-24 8:19 ` [tip:perf/core] perf evsel: " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 03/19] perf, tools, stat: Fix saved values rbtree lookup Andi Kleen
2017-08-11 23:26 ` [PATCH v2 04/19] perf, tools: Tighten detection of BPF events Andi Kleen
2017-08-22 8:20 ` Jiri Olsa
2017-08-22 15:00 ` Arnaldo Carvalho de Melo
2017-08-24 8:20 ` [tip:perf/core] perf bpf: " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 05/19] perf, tools: Support weak groups Andi Kleen
2017-08-22 8:34 ` Jiri Olsa
2017-08-22 20:58 ` Andi Kleen
2017-08-23 7:40 ` Jiri Olsa
2017-08-22 8:36 ` Jiri Olsa
2017-08-22 21:00 ` Andi Kleen
2017-08-11 23:26 ` [PATCH v2 06/19] perf, tools: Add missing newline to expr parser error messages Andi Kleen
2017-08-11 23:26 ` [PATCH v2 07/19] perf, tools: Add utility function to detect SMT status Andi Kleen
2017-08-22 8:45 ` Jiri Olsa
2017-08-22 15:16 ` Arnaldo Carvalho de Melo
2017-08-24 8:20 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 08/19] perf, tools: Expression parser enhancements for metrics Andi Kleen
2017-08-22 8:45 ` Jiri Olsa
2017-08-22 15:16 ` Arnaldo Carvalho de Melo
2017-08-23 17:43 ` Jiri Olsa
2017-08-24 8:21 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 09/19] perf, tools: Increase maximum number of events in expressions Andi Kleen
2017-08-22 8:45 ` Jiri Olsa
2017-08-22 15:17 ` Arnaldo Carvalho de Melo
2017-08-24 8:21 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 10/19] perf, tools: Dedup events in expression parsing Andi Kleen
2017-08-22 8:46 ` Jiri Olsa
2017-08-24 8:21 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 11/19] perf, tools: Support metric_group and no event name in json parser Andi Kleen
2017-08-11 23:26 ` [PATCH v2 12/19] perf, tools, stat: Factor out generic metric printing Andi Kleen
2017-08-28 9:19 ` Jiri Olsa
2017-08-11 23:26 ` [PATCH v2 13/19] perf, tools: Print generic metric header even for failed expressions Andi Kleen
2017-08-11 23:26 ` [PATCH v2 14/19] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen
2017-08-28 8:13 ` Jiri Olsa
2017-08-28 9:19 ` Jiri Olsa
2017-08-28 9:19 ` Jiri Olsa
2017-08-28 16:46 ` Andi Kleen
2017-08-11 23:26 ` [PATCH v2 15/19] perf, tools, list: Add metric groups to perf list Andi Kleen
2017-08-11 23:26 ` [PATCH v2 16/19] perf, tools, stat: Don't use ctx for saved values lookup Andi Kleen
2017-08-11 23:26 ` [PATCH v2 17/19] perf, tools, stat: Support duration_time for metrics Andi Kleen
2017-08-28 9:19 ` Jiri Olsa
2017-08-28 16:47 ` Andi Kleen
2017-08-11 23:26 ` [PATCH v2 18/19] perf, tools, stat: Hide internal duration_time counter Andi Kleen
2017-08-11 23:26 ` [PATCH v2 19/19] perf, tools, stat: Update walltime_nsecs_stats in interval mode Andi Kleen
2017-08-14 20:15 ` [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Jiri Olsa
2017-08-14 20:39 ` Andi Kleen
2017-08-14 21:12 ` Jiri Olsa
2017-08-22 8:20 ` Jiri Olsa
2017-08-22 14:40 ` Arnaldo Carvalho de Melo
2017-08-22 14:44 ` Jiri Olsa
2017-08-22 15:07 ` Arnaldo Carvalho de Melo
2017-08-24 8:19 ` tip-bot for Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-d74be47673676eded2f0bb8274e752bed32c42d8@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox