Re: [PATCH 3/3] perf_event: fix __dsos__write_buildid_table()

OGAWA Hirofumi
2009-12-07T05:19:08Z

Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> writes:

> The remain buff size is 'len - pos->long_name_len - 1', not
> 'len - pos->long_name_len + 1'
>
> This bug is imported by:
> Commit-ID: 7691b1ec2e4a8d4bd88dcf88b29792399ebe1c91
> Gitweb: http://git.kernel.org/tip/7691b1ec2e4a8d4bd88dcf88b29792399ebe1c91
> Author: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> AuthorDate: Sun, 6 Dec 2009 20:10:49 +0900
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Sun, 6 Dec 2009 18:15:02 +0100
>
> perf tools: Misc small fixes

Oops, I forgot parens. Thanks for fixing it.

> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> ---
> tools/perf/util/header.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 08b6759..59a9c0b 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -209,7 +209,7 @@ static int __dsos__write_buildid_table(struct list_head *head, int fd)
> err = do_write(fd, pos->long_name, pos->long_name_len + 1);
> if (err < 0)
> return err;
> - err = do_write(fd, zero_buf, len - pos->long_name_len + 1);
> + err = do_write(fd, zero_buf, len - pos->long_name_len - 1);
> if (err < 0)
> return err;
> }

--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>