From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759442AbbJ3JTS (ORCPT ); Fri, 30 Oct 2015 05:19:18 -0400 Received: from terminus.zytor.com ([198.137.202.10]:44552 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759426AbbJ3JTP (ORCPT ); Fri, 30 Oct 2015 05:19:15 -0400 Date: Fri, 30 Oct 2015 02:18:41 -0700 From: tip-bot for David Woodhouse Message-ID: Cc: dwmw2@infradead.org, hpa@zytor.com, mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, David.Woodhouse@intel.com Reply-To: mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, David.Woodhouse@intel.com, dwmw2@infradead.org, hpa@zytor.com In-Reply-To: <1446016471.3405.201.camel@infradead.org> References: <1446016471.3405.201.camel@infradead.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] Document that IRQ_NONE should be returned when IRQ not actually handled Git-Commit-ID: d9e4ad5badf4ccbfddee208c898fb8fd0c8836b1 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: d9e4ad5badf4ccbfddee208c898fb8fd0c8836b1 Gitweb: http://git.kernel.org/tip/d9e4ad5badf4ccbfddee208c898fb8fd0c8836b1 Author: David Woodhouse AuthorDate: Wed, 28 Oct 2015 16:14:31 +0900 Committer: Thomas Gleixner CommitDate: Fri, 30 Oct 2015 10:13:26 +0100 Document that IRQ_NONE should be returned when IRQ not actually handled Our IRQ storm detection works when an interrupt handler returns IRQ_NONE for thousands of consecutive interrupts in a second. It doesn't hurt to occasionally return IRQ_NONE when the interrupt is actually genuine. Drivers should only be returning IRQ_HANDLED if they have actually *done* something to stop an interrupt from happening — it doesn't just mean "this really *was* my device". Signed-off-by: David Woodhouse Cc: davem@davemloft.net Link: http://lkml.kernel.org/r/1446016471.3405.201.camel@infradead.org Signed-off-by: Thomas Gleixner --- include/linux/irqreturn.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/irqreturn.h b/include/linux/irqreturn.h index e374e36..eb1bdcf 100644 --- a/include/linux/irqreturn.h +++ b/include/linux/irqreturn.h @@ -3,7 +3,7 @@ /** * enum irqreturn - * @IRQ_NONE interrupt was not from this device + * @IRQ_NONE interrupt was not from this device or was not handled * @IRQ_HANDLED interrupt was handled by this device * @IRQ_WAKE_THREAD handler requests to wake the handler thread */