From: tip-bot for Suresh Siddha <suresh.b.siddha@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
a.p.zijlstra@chello.nl, suresh.b.siddha@intel.com,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/urgent] sched: Move sched_avg_update() to update_cpu_load()
Date: Thu, 9 Sep 2010 19:45:51 GMT [thread overview]
Message-ID: <tip-da2b71edd8a7db44fe1746261410a981f3e03632@git.kernel.org> (raw)
In-Reply-To: <1282596171.2694.3.camel@sbsiddha-MOBL3>
Commit-ID: da2b71edd8a7db44fe1746261410a981f3e03632
Gitweb: http://git.kernel.org/tip/da2b71edd8a7db44fe1746261410a981f3e03632
Author: Suresh Siddha <suresh.b.siddha@intel.com>
AuthorDate: Mon, 23 Aug 2010 13:42:51 -0700
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 9 Sep 2010 20:39:33 +0200
sched: Move sched_avg_update() to update_cpu_load()
Currently sched_avg_update() (which updates rt_avg stats in the rq)
is getting called from scale_rt_power() (in the load balance context)
which doesn't take rq->lock.
Fix it by moving the sched_avg_update() to more appropriate
update_cpu_load() where the CFS load gets updated as well.
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1282596171.2694.3.camel@sbsiddha-MOBL3>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched.c | 6 ++++++
kernel/sched_fair.c | 2 --
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 09b574e..ed09d4f 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -1294,6 +1294,10 @@ static void resched_task(struct task_struct *p)
static void sched_rt_avg_update(struct rq *rq, u64 rt_delta)
{
}
+
+static void sched_avg_update(struct rq *rq)
+{
+}
#endif /* CONFIG_SMP */
#if BITS_PER_LONG == 32
@@ -3182,6 +3186,8 @@ static void update_cpu_load(struct rq *this_rq)
this_rq->cpu_load[i] = (old_load * (scale - 1) + new_load) >> i;
}
+
+ sched_avg_update(this_rq);
}
static void update_cpu_load_active(struct rq *this_rq)
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index ab661eb..f53ec75 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -2268,8 +2268,6 @@ unsigned long scale_rt_power(int cpu)
struct rq *rq = cpu_rq(cpu);
u64 total, available;
- sched_avg_update(rq);
-
total = sched_avg_period() + (rq->clock - rq->age_stamp);
available = total - rq->rt_avg;
prev parent reply other threads:[~2010-09-09 19:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 19:45 [patch 0/3] sched: fixes related to scaling down cpu power with RT tasks Suresh Siddha
2010-08-13 19:45 ` [patch 1/3] sched: init rt_avg stat whenever rq comes online Suresh Siddha
2010-08-16 7:47 ` Peter Zijlstra
2010-08-16 17:36 ` Suresh Siddha
2010-08-16 19:25 ` Peter Zijlstra
2010-08-17 8:51 ` Peter Zijlstra
2010-08-19 0:20 ` Suresh Siddha
2010-08-19 8:53 ` Peter Zijlstra
2010-08-20 0:03 ` Suresh Siddha
2010-08-20 8:54 ` Peter Zijlstra
2010-08-20 14:16 ` [tip:sched/urgent] x86, tsc, sched: Recompute cyc2ns_offset's during resume from sleep states tip-bot for Suresh Siddha
2010-08-13 19:45 ` [patch 2/3] sched: fix minimum power returned by update_cpu_power() Suresh Siddha
2010-08-16 7:50 ` Peter Zijlstra
2010-08-16 17:37 ` Suresh Siddha
2010-08-13 19:45 ` [patch 3/3] sched: move sched_avg_update() to update_cpu_load() Suresh Siddha
2010-08-16 8:00 ` Peter Zijlstra
2010-08-16 17:46 ` Suresh Siddha
2010-08-16 19:31 ` Peter Zijlstra
2010-08-20 0:51 ` Suresh Siddha
2010-08-20 9:25 ` Peter Zijlstra
2010-08-20 13:47 ` Peter Zijlstra
2010-08-23 20:42 ` Suresh Siddha
2010-09-09 19:45 ` tip-bot for Suresh Siddha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-da2b71edd8a7db44fe1746261410a981f3e03632@git.kernel.org \
--to=suresh.b.siddha@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).