From: tip-bot for Alexey Brodkin <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: Vineet.Gupta1@synopsys.com, tglx@linutronix.de, hpa@zytor.com,
linux-kernel@vger.kernel.org, namhyung@kernel.org, bp@suse.de,
peterz@infradead.org, mingo@kernel.org, acme@redhat.com,
abrodkin@synopsys.com, jolsa@kernel.org, dev@codyps.com
Subject: [tip:perf/urgent] perf tools: Fix statfs.f_type data type mismatch build error with uclibc
Date: Sat, 17 Jan 2015 02:11:49 -0800 [thread overview]
Message-ID: <tip-db1806edcfef007d9594435a331dcf7e7f1b8fac@git.kernel.org> (raw)
In-Reply-To: <1420888254-17504-2-git-send-email-vgupta@synopsys.com>
Commit-ID: db1806edcfef007d9594435a331dcf7e7f1b8fac
Gitweb: http://git.kernel.org/tip/db1806edcfef007d9594435a331dcf7e7f1b8fac
Author: Alexey Brodkin <abrodkin@synopsys.com>
AuthorDate: Sat, 10 Jan 2015 16:40:50 +0530
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 16 Jan 2015 17:49:29 -0300
perf tools: Fix statfs.f_type data type mismatch build error with uclibc
ARC Linux uses the no legacy syscalls abi and corresponding uClibc headers
statfs defines f_type to be U32 which causes perf build breakage
http://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common-generic/bits/statfs.h
----------->8---------------
CC fs/fs.o
fs/fs.c: In function 'fs__valid_mount':
fs/fs.c:82:24: error: comparison between signed and unsigned integer
expressions [-Werror=sign-compare]
else if (st_fs.f_type != magic)
^
cc1: all warnings being treated as errors
----------->8---------------
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Borislav Petkov <bp@suse.de>
Cc: Cody P Schafer <dev@codyps.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Link: http://lkml.kernel.org/r/1420888254-17504-2-git-send-email-vgupta@synopsys.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/api/fs/debugfs.c | 2 +-
tools/lib/api/fs/fs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c
index a74fba6..86ea2d7 100644
--- a/tools/lib/api/fs/debugfs.c
+++ b/tools/lib/api/fs/debugfs.c
@@ -67,7 +67,7 @@ int debugfs_valid_mountpoint(const char *debugfs)
if (statfs(debugfs, &st_fs) < 0)
return -ENOENT;
- else if (st_fs.f_type != (long) DEBUGFS_MAGIC)
+ else if ((long)st_fs.f_type != (long)DEBUGFS_MAGIC)
return -ENOENT;
return 0;
diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c
index 65d9be3..128ef63 100644
--- a/tools/lib/api/fs/fs.c
+++ b/tools/lib/api/fs/fs.c
@@ -79,7 +79,7 @@ static int fs__valid_mount(const char *fs, long magic)
if (statfs(fs, &st_fs) < 0)
return -ENOENT;
- else if (st_fs.f_type != magic)
+ else if ((long)st_fs.f_type != magic)
return -ENOENT;
return 0;
next prev parent reply other threads:[~2015-01-17 10:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 11:10 [PATCH v2 0/5] Perf tool fixes for ARC + uClibc Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 1/5] perf tools: [uclibc] fix statfs.f_type data type mismatch build error Vineet Gupta
2015-01-12 11:05 ` Jiri Olsa
2015-01-13 1:47 ` Arnaldo Carvalho de Melo
2015-01-13 4:49 ` Vineet Gupta
2015-01-17 10:11 ` tip-bot for Alexey Brodkin [this message]
2015-01-10 11:10 ` [PATCH v2 2/5] perf tools: [uclibc] Elide strlcpy warning Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 3/5] perf tools: [uclibc] Avoid build splat for syscall numbers Vineet Gupta
2015-01-12 11:09 ` Jiri Olsa
2015-01-12 12:00 ` Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 4/5] perf tools: [uclibc] don't rely on glibc malloc working for sz 0 Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 5/5] perf tools: [uclibc] provide stub for pthread_attr_setaffinity_np Vineet Gupta
2015-01-12 11:04 ` Jiri Olsa
2015-01-12 11:13 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-db1806edcfef007d9594435a331dcf7e7f1b8fac@git.kernel.org \
--to=tipbot@zytor.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=abrodkin@synopsys.com \
--cc=acme@redhat.com \
--cc=bp@suse.de \
--cc=dev@codyps.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox