public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Davidlohr Bueso <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, torvalds@linux-foundation.org,
	peterz@infradead.org, jason.low2@hp.com,
	peter@hurleysoftware.com, clm@fb.com, riel@redhat.com,
	alex.shi@linaro.org, akpm@linux-foundation.org,
	aarcange@redhat.com, tglx@linutronix.de, davidlohr@hp.com,
	linux-kernel@vger.kernel.org, hpa@zytor.com, andi@firstfloor.org,
	tim.c.chen@linux.intel.com, paulmck@linux.vnet.ibm.com,
	jbacik@fusionio.com, walken@google.com
Subject: [tip:locking/core] locking/rwsem: Fix warnings for CONFIG_RWSEM_GENERIC_SPINLOCK
Date: Thu, 5 Jun 2014 07:32:58 -0700	[thread overview]
Message-ID: <tip-dbb5eafa23fdb7a00d64b04e23a3efc59d6474cb@git.kernel.org> (raw)
In-Reply-To: <1400545677.6399.10.camel@buesod1.americas.hpqcorp.net>

Commit-ID:  dbb5eafa23fdb7a00d64b04e23a3efc59d6474cb
Gitweb:     http://git.kernel.org/tip/dbb5eafa23fdb7a00d64b04e23a3efc59d6474cb
Author:     Davidlohr Bueso <davidlohr@hp.com>
AuthorDate: Mon, 19 May 2014 17:27:57 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 5 Jun 2014 10:38:45 +0200

locking/rwsem: Fix warnings for CONFIG_RWSEM_GENERIC_SPINLOCK

Optimistic spinning is only used by the xadd variant
of rw-semaphores. Make sure that we use the old version
of the __RWSEM_INITIALIZER macro for systems that rely
on the spinlock one, otherwise warnings can be triggered,
such as the following reported on an arm box:

  ipc/ipcns_notifier.c:22:8: warning: excess elements in struct initializer [enabled by default]
  ipc/ipcns_notifier.c:22:8: warning: (near initialization for 'ipcns_chain.rwsem') [enabled by default]
  ipc/ipcns_notifier.c:22:8: warning: excess elements in struct initializer [enabled by default]
  ipc/ipcns_notifier.c:22:8: warning: (near initialization for 'ipcns_chain.rwsem') [enabled by default]

Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
Cc: Michel Lespinasse <walken@google.com>
Cc: Peter Hurley <peter@hurleysoftware.com>
Cc: Alex Shi <alex.shi@linaro.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jason Low <jason.low2@hp.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Chris Mason <clm@fb.com>
Cc: Josef Bacik <jbacik@fusionio.com>
Link: http://lkml.kernel.org/r/1400545677.6399.10.camel@buesod1.americas.hpqcorp.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 include/linux/rwsem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
index 3e108f1..8d79708 100644
--- a/include/linux/rwsem.h
+++ b/include/linux/rwsem.h
@@ -64,7 +64,7 @@ static inline int rwsem_is_locked(struct rw_semaphore *sem)
 # define __RWSEM_DEP_MAP_INIT(lockname)
 #endif
 
-#ifdef CONFIG_SMP
+#if defined(CONFIG_SMP) && !defined(CONFIG_RWSEM_GENERIC_SPINLOCK)
 #define __RWSEM_INITIALIZER(name)			\
 	{ RWSEM_UNLOCKED_VALUE,				\
 	  __RAW_SPIN_LOCK_UNLOCKED(name.wait_lock),	\

  parent reply	other threads:[~2014-06-05 14:34 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 22:19 [PATCH] rwsem: Support optimistic spinning Davidlohr Bueso
2014-04-28  5:19 ` Davidlohr Bueso
2014-04-28  7:52 ` Peter Zijlstra
2014-04-28 17:18   ` Davidlohr Bueso
2014-04-28 22:09 ` [PATCH v2] " Davidlohr Bueso
2014-04-28 23:10   ` Paul E. McKenney
2014-04-29  0:50     ` Tim Chen
2014-04-29  3:05       ` Davidlohr Bueso
2014-04-29 15:11       ` Paul E. McKenney
2014-04-29 16:00         ` Tim Chen
2014-06-04 17:57         ` Andev
2014-06-04 19:44           ` Davidlohr Bueso
2014-04-30  8:01   ` Peter Zijlstra
2014-04-30  8:27   ` Peter Zijlstra
2014-04-30 16:17     ` Davidlohr Bueso
2014-04-30 17:50     ` Tim Chen
2014-04-30 18:04       ` Peter Zijlstra
2014-04-30 18:08         ` Tim Chen
2014-04-30 21:01           ` Tim Chen
2014-04-30 21:06             ` Davidlohr Bueso
2014-04-30 21:28               ` Tim Chen
2014-04-30  9:04   ` Peter Zijlstra
2014-04-30 16:33     ` Jason Low
2014-04-30 16:50       ` Peter Zijlstra
2014-04-30  9:14   ` Peter Zijlstra
2014-04-30 16:23     ` Davidlohr Bueso
2014-04-30  9:21   ` Peter Zijlstra
2014-04-30 16:32     ` Davidlohr Bueso
2014-04-30 16:37       ` Peter Zijlstra
2014-04-30 10:00   ` Peter Zijlstra
2014-04-30 16:42     ` Davidlohr Bueso
2014-05-01  3:21 ` [PATCH v3] " Davidlohr Bueso
2014-05-01 16:39   ` Tim Chen
2014-05-01 20:32     ` Jason Low
2014-05-02 18:24 ` [PATCH v4] " Davidlohr Bueso
2014-05-19 13:12   ` [tip:locking/core] " tip-bot for Davidlohr Bueso
2014-05-19 21:47     ` Davidlohr Bueso
2014-05-19 22:39       ` Davidlohr Bueso
2014-05-19 23:14         ` Jason Low
2014-05-20  0:27           ` Davidlohr Bueso
2014-05-20  0:54             ` [tip:locking/core] rwsem: Fix warnings for CONFIG_RWSEM_GENERIC_SPINLOCK tip-bot for Davidlohr Bueso
2014-06-05 14:32             ` tip-bot for Davidlohr Bueso [this message]
2014-06-05  8:38   ` [PATCH v4] rwsem: Support optimistic spinning Ingo Molnar
2014-06-05 16:03     ` Tim Chen
2014-06-05 14:32   ` [tip:locking/core] locking/rwsem: " tip-bot for Davidlohr Bueso
2014-05-14 15:01 ` [PATCH v5] rwsem: " Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-dbb5eafa23fdb7a00d64b04e23a3efc59d6474cb@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@linaro.org \
    --cc=andi@firstfloor.org \
    --cc=clm@fb.com \
    --cc=davidlohr@hp.com \
    --cc=hpa@zytor.com \
    --cc=jason.low2@hp.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peter@hurleysoftware.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox