linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "tip-bot for H. Peter Anvin" <hpa@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	suresh.b.siddha@intel.com, tglx@linutronix.de, avi@redhat.com
Subject: [tip:x86/fpu] x86, fpu: Use the proper asm constraint in use_xsave()
Date: Wed, 12 May 2010 00:18:44 GMT	[thread overview]
Message-ID: <tip-dce8bf4e115aa44d590802ce3554e926840c9042@git.kernel.org> (raw)
In-Reply-To: <1273135546-29690-2-git-send-email-avi@redhat.com>

Commit-ID:  dce8bf4e115aa44d590802ce3554e926840c9042
Gitweb:     http://git.kernel.org/tip/dce8bf4e115aa44d590802ce3554e926840c9042
Author:     H. Peter Anvin <hpa@zytor.com>
AuthorDate: Mon, 10 May 2010 13:41:41 -0700
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Mon, 10 May 2010 13:41:41 -0700

x86, fpu: Use the proper asm constraint in use_xsave()

The proper constraint for a receiving 8-bit variable is "=qm", not
"=g" which equals "=rim"; even though the "i" will never match, bugs
can and do happen due to the difference between "q" and "r".

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Avi Kivity <avi@redhat.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
LKML-Reference: <1273135546-29690-2-git-send-email-avi@redhat.com>
---
 arch/x86/include/asm/i387.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h
index 1a8cca3..8002e9c 100644
--- a/arch/x86/include/asm/i387.h
+++ b/arch/x86/include/asm/i387.h
@@ -64,7 +64,7 @@ static inline bool use_xsave(void)
 	alternative_io("mov $0, %0",
 		       "mov $1, %0",
 		       X86_FEATURE_XSAVE,
-		       "=g"(has_xsave));
+		       "=qm" (has_xsave));
 
 	return has_xsave;
 }

  parent reply	other threads:[~2010-05-12  0:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06  8:45 [PATCH v3 0/2] x86 FPU API Avi Kivity
2010-05-06  8:45 ` [PATCH v3 1/2] x86: eliminate TS_XSAVE Avi Kivity
2010-05-10 20:39   ` [tip:x86/fpu] x86: Eliminate TS_XSAVE tip-bot for Avi Kivity
2010-05-12  0:18   ` tip-bot for H. Peter Anvin [this message]
2010-05-12  1:06   ` [tip:x86/fpu] x86: Add new static_cpu_has() function using alternatives tip-bot for H. Peter Anvin
2010-05-18 20:10     ` Eric Dumazet
2010-05-18 20:43       ` H. Peter Anvin
2010-05-18 20:57       ` H. Peter Anvin
2010-05-18 21:11         ` Eric Dumazet
2010-05-18 21:31           ` H. Peter Anvin
2010-05-18 21:38           ` Does anyone care about gcc 3.x support for x86 anymore? H. Peter Anvin
2010-05-19 23:10             ` Mauro Carvalho Chehab
2010-05-20  0:39               ` H. Peter Anvin
2010-05-20  0:42               ` H. Peter Anvin
2010-05-20 12:44                 ` Ingo Molnar
2010-05-18 20:58       ` [tip:x86/fpu] x86: Add new static_cpu_has() function using alternatives H. Peter Anvin
2010-05-18 21:31         ` Eric Dumazet
2010-05-27 20:12         ` [tip:x86/urgent] x86, cpufeature: Unbreak compile with gcc 3.x tip-bot for H. Peter Anvin
2010-05-12  1:06   ` [tip:x86/fpu] x86, fpu: Use static_cpu_has() to implement use_xsave() tip-bot for H. Peter Anvin
2010-05-06  8:45 ` [PATCH v3 2/2] x86: Introduce 'struct fpu' and related API Avi Kivity
2010-05-10 20:39   ` [tip:x86/fpu] " tip-bot for Avi Kivity
2010-05-10 20:40   ` [tip:x86/fpu] x86, fpu: Unbreak FPU emulation tip-bot for H. Peter Anvin
2010-05-10  8:48 ` [PATCH v3 0/2] x86 FPU API Avi Kivity
2010-05-10 15:24   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-dce8bf4e115aa44d590802ce3554e926840c9042@git.kernel.org \
    --to=hpa@zytor.com \
    --cc=avi@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).