From: Jan Beulich <jbeulich@novell.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
jbeulich@novell.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/asm] x86-64: remove unnecessary spill/reload of rbx from memcpy
Date: Thu, 12 Mar 2009 11:57:45 GMT [thread overview]
Message-ID: <tip-dd1ef4ec4721ddc0a1f2b73a4f67930cb320665c@git.kernel.org> (raw)
In-Reply-To: <49B8F641.76E4.0078.0@novell.com>
Commit-ID: dd1ef4ec4721ddc0a1f2b73a4f67930cb320665c
Gitweb: http://git.kernel.org/tip/dd1ef4ec4721ddc0a1f2b73a4f67930cb320665c
Author: "Jan Beulich" <jbeulich@novell.com>
AuthorDate: Thu, 12 Mar 2009 10:47:13 +0000
Commit: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 12 Mar 2009 12:04:47 +0100
x86-64: remove unnecessary spill/reload of rbx from memcpy
Impact: micro-optimization
This should slightly improve its performance.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
LKML-Reference: <49B8F641.76E4.0078.0@novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/lib/memcpy_64.S | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/arch/x86/lib/memcpy_64.S b/arch/x86/lib/memcpy_64.S
index c22981f..10c0676 100644
--- a/arch/x86/lib/memcpy_64.S
+++ b/arch/x86/lib/memcpy_64.S
@@ -33,9 +33,6 @@ ENDPROC(memcpy_c)
ENTRY(__memcpy)
ENTRY(memcpy)
CFI_STARTPROC
- pushq %rbx
- CFI_ADJUST_CFA_OFFSET 8
- CFI_REL_OFFSET rbx, 0
movq %rdi,%rax
movl %edx,%ecx
@@ -102,11 +99,7 @@ ENTRY(memcpy)
jnz .Lloop_1
.Lende:
- popq %rbx
- CFI_ADJUST_CFA_OFFSET -8
- CFI_RESTORE rbx
ret
-.Lfinal:
CFI_ENDPROC
ENDPROC(memcpy)
ENDPROC(__memcpy)
prev parent reply other threads:[~2009-03-12 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 10:47 [PATCH] x86-64: remove unnecessary spill/reload of rbx from memcpy Jan Beulich
2009-03-12 11:57 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-dd1ef4ec4721ddc0a1f2b73a4f67930cb320665c@git.kernel.org \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox