From: tip-bot for Denys Vlasenko <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: bp@alien8.de, linux-kernel@vger.kernel.org, wad@chromium.org,
oleg@redhat.com, keescook@chromium.org, dvlasenk@redhat.com,
rostedt@goodmis.org, tglx@linutronix.de, mingo@kernel.org,
brgerst@gmail.com, fweisbec@gmail.com,
torvalds@linux-foundation.org, luto@kernel.org, ast@plumgrid.com,
hpa@zytor.com
Subject: [tip:x86/asm] x86/asm/entry/64: Tidy up JZ insns after TESTs
Date: Fri, 8 May 2015 02:25:26 -0700 [thread overview]
Message-ID: <tip-dde74f2e4a4447ef838c57e407f7139de3df68cb@git.kernel.org> (raw)
In-Reply-To: <1430140912-7960-1-git-send-email-dvlasenk@redhat.com>
Commit-ID: dde74f2e4a4447ef838c57e407f7139de3df68cb
Gitweb: http://git.kernel.org/tip/dde74f2e4a4447ef838c57e407f7139de3df68cb
Author: Denys Vlasenko <dvlasenk@redhat.com>
AuthorDate: Mon, 27 Apr 2015 15:21:51 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 8 May 2015 11:07:31 +0200
x86/asm/entry/64: Tidy up JZ insns after TESTs
After TESTs, use logically correct JZ/JNZ mnemonics instead of
JE/JNE. This doesn't change code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Acked-by: Andy Lutomirski <luto@kernel.org>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Drewry <wad@chromium.org>
Link: http://lkml.kernel.org/r/1430140912-7960-1-git-send-email-dvlasenk@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/entry_64.S | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index e952f6b..8f8b22a 100644
--- a/arch/x86/kernel/entry_64.S
+++ b/arch/x86/kernel/entry_64.S
@@ -666,7 +666,7 @@ END(irq_entries_start)
leaq -RBP(%rsp),%rdi /* arg1 for \func (pointer to pt_regs) */
testl $3, CS-RBP(%rsp)
- je 1f
+ jz 1f
SWAPGS
1:
/*
@@ -721,7 +721,7 @@ ret_from_intr:
CFI_ADJUST_CFA_OFFSET RBP
testl $3,CS(%rsp)
- je retint_kernel
+ jz retint_kernel
/* Interrupt came from user space */
GET_THREAD_INFO(%rcx)
@@ -1310,7 +1310,7 @@ ENTRY(error_entry)
SAVE_EXTRA_REGS 8
xorl %ebx,%ebx
testl $3,CS+8(%rsp)
- je error_kernelspace
+ jz error_kernelspace
error_swapgs:
SWAPGS
error_sti:
@@ -1361,7 +1361,7 @@ ENTRY(error_exit)
TRACE_IRQS_OFF
GET_THREAD_INFO(%rcx)
testl %eax,%eax
- jne retint_kernel
+ jnz retint_kernel
LOCKDEP_SYS_EXIT_IRQ
movl TI_flags(%rcx),%edx
movl $_TIF_WORK_MASK,%edi
prev parent reply other threads:[~2015-05-08 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 13:21 [PATCH 1/2] x86/asm/entry/64: Tidy up JZ insns after TESTs Denys Vlasenko
2015-04-27 13:21 ` [PATCH 2/2] x86/asm/entry/64: Clean up usage of TEST insns Denys Vlasenko
2015-05-08 9:25 ` [tip:x86/asm] " tip-bot for Denys Vlasenko
2015-04-27 21:13 ` [PATCH 1/2] x86/asm/entry/64: Tidy up JZ insns after TESTs Andy Lutomirski
2015-04-27 22:16 ` H. Peter Anvin
2015-04-28 10:05 ` Denys Vlasenko
2015-05-08 9:25 ` tip-bot for Denys Vlasenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-dde74f2e4a4447ef838c57e407f7139de3df68cb@git.kernel.org \
--to=tipbot@zytor.com \
--cc=ast@plumgrid.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).