From: tip-bot for Byungchul Park <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org,
peterz@infradead.org, byungchul.park@lge.com, mingo@kernel.org,
bristot@redhat.com, torvalds@linux-foundation.org,
kernel-team@lge.com, tglx@linutronix.de, rostedt@goodmis.org,
juri.lelli@arm.com
Subject: [tip:sched/core] sched/rt: Remove unnecessary condition in push_rt_task()
Date: Tue, 23 May 2017 01:44:50 -0700 [thread overview]
Message-ID: <tip-de16b91effdbf5aeff8346b99bcd0991a5362db9@git.kernel.org> (raw)
In-Reply-To: <1494551143-22219-1-git-send-email-byungchul.park@lge.com>
Commit-ID: de16b91effdbf5aeff8346b99bcd0991a5362db9
Gitweb: http://git.kernel.org/tip/de16b91effdbf5aeff8346b99bcd0991a5362db9
Author: Byungchul Park <byungchul.park@lge.com>
AuthorDate: Fri, 12 May 2017 10:05:43 +0900
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 23 May 2017 10:01:33 +0200
sched/rt: Remove unnecessary condition in push_rt_task()
pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when
it returns a task other than NULL, which means that task_cpu(task) must
be rq->cpu. So if task == next_task, then task_cpu(next_task) must be
rq->cpu as well. Remove the redundant condition and make the code simpler.
This way one unnecessary branch and two LOAD operations can be avoided.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: Juri Lelli <juri.lelli@arm.com>
Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: <kernel-team@lge.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1494551143-22219-1-git-send-email-byungchul.park@lge.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/rt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 979b734..c18b500 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1819,7 +1819,7 @@ retry:
* pushing.
*/
task = pick_next_pushable_task(rq);
- if (task_cpu(next_task) == rq->cpu && task == next_task) {
+ if (task == next_task) {
/*
* The task hasn't migrated, and is still the next
* eligible task, but we failed to find a run-queue
prev parent reply other threads:[~2017-05-23 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 1:05 [RESEND PATCH v3] sched/rt: Remove unnecessary condition in push_rt_task() Byungchul Park
2017-05-18 2:01 ` Byungchul Park
2017-05-23 8:44 ` tip-bot for Byungchul Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-de16b91effdbf5aeff8346b99bcd0991a5362db9@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bristot@redhat.com \
--cc=byungchul.park@lge.com \
--cc=hpa@zytor.com \
--cc=juri.lelli@arm.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox