From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759434AbcBYFtL (ORCPT ); Thu, 25 Feb 2016 00:49:11 -0500 Received: from torg.zytor.com ([198.137.202.12]:53718 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756493AbcBYFtH (ORCPT ); Thu, 25 Feb 2016 00:49:07 -0500 Date: Wed, 24 Feb 2016 21:46:55 -0800 From: tip-bot for Josh Poimboeuf Message-ID: Cc: bernd@petrovitsch.priv.at, namhyung@gmail.com, tglx@linutronix.de, chris.j.arges@canonical.com, akpm@linux-foundation.org, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, luto@amacapital.net, acme@kernel.org, hpa@zytor.com, mmarek@suse.cz, torvalds@linux-foundation.org, jpoimboe@redhat.com, jslaby@suse.cz, palves@redhat.com, mingo@kernel.org, bp@suse.de, brgerst@gmail.com, peterz@infradead.org, bp@alien8.de, luto@kernel.org Reply-To: chris.j.arges@canonical.com, tglx@linutronix.de, akpm@linux-foundation.org, bernd@petrovitsch.priv.at, namhyung@gmail.com, dvlasenk@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, hpa@zytor.com, torvalds@linux-foundation.org, mmarek@suse.cz, jpoimboe@redhat.com, jslaby@suse.cz, mingo@kernel.org, palves@redhat.com, bp@suse.de, brgerst@gmail.com, peterz@infradead.org, bp@alien8.de, luto@kernel.org In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/debug] x86/amd: Set ELF function type for vide() Git-Commit-ID: de642faf48670c3c8eae5899177f786c624f4894 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: de642faf48670c3c8eae5899177f786c624f4894 Gitweb: http://git.kernel.org/tip/de642faf48670c3c8eae5899177f786c624f4894 Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:14 -0600 Committer: Ingo Molnar CommitDate: Wed, 24 Feb 2016 08:35:42 +0100 x86/amd: Set ELF function type for vide() vide() is a callable function, but is missing the ELF function type, which confuses tools like stacktool. Properly annotate it to be a callable function. The generated code is unchanged. Signed-off-by: Josh Poimboeuf Reviewed-by: Borislav Petkov Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/a324095f5c9390ff39b15b4562ea1bbeda1a8282.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/cpu/amd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index a07956a..fe2f089 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -75,7 +75,10 @@ static inline int wrmsrl_amd_safe(unsigned msr, unsigned long long val) */ extern __visible void vide(void); -__asm__(".globl vide\n\t.align 4\nvide: ret"); +__asm__(".globl vide\n" + ".type vide, @function\n" + ".align 4\n" + "vide: ret\n"); static void init_amd_k5(struct cpuinfo_x86 *c) {