From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946085AbbEVJLD (ORCPT ); Fri, 22 May 2015 05:11:03 -0400 Received: from terminus.zytor.com ([198.137.202.10]:58607 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422730AbbEVJKw (ORCPT ); Fri, 22 May 2015 05:10:52 -0400 Date: Fri, 22 May 2015 02:10:26 -0700 From: tip-bot for Geert Uytterhoeven Message-ID: Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de, rogerq@ti.com, gregory.clement@free-electrons.com, mingo@kernel.org, geert+renesas@glider.be Reply-To: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, gregory.clement@free-electrons.com, mingo@kernel.org, rogerq@ti.com, geert+renesas@glider.be In-Reply-To: <1432281529-23325-1-git-send-email-geert+renesas@glider.be> References: <1432281529-23325-1-git-send-email-geert+renesas@glider.be> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] genirq: Set IRQCHIP_SKIP_SET_WAKE for no_irq_chip Git-Commit-ID: de8d1810fda5463ee60ba2937ca68e55a52bd9e7 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: de8d1810fda5463ee60ba2937ca68e55a52bd9e7 Gitweb: http://git.kernel.org/tip/de8d1810fda5463ee60ba2937ca68e55a52bd9e7 Author: Geert Uytterhoeven AuthorDate: Fri, 22 May 2015 09:58:49 +0200 Committer: Thomas Gleixner CommitDate: Fri, 22 May 2015 11:06:47 +0200 genirq: Set IRQCHIP_SKIP_SET_WAKE for no_irq_chip If no_irq_chip is used for wake up (e.g. gpio-keys with a simple GPIO controller), the following warning is printed on resume from s2ram: WANING: CPU: 0 PID: 1046 at kernel/irq/manage.c:537 irq_set_irq_wake+0x9c/0xf8() Unbalanced IRQ 113 wake disable This happens because no_irq_chip does not implement irq_chip.irq_set_wake(), causing set_irq_wake_real() to return -ENXIO, and irq_set_irq_wake() to reset the wake_depth to zero. Set IRQCHIP_SKIP_SET_WAKE to indicate that irq_chip.irq_set_wake() is not implemented. Cfr. commit 10a50f1ab5f06c9a ("genirq: Set IRQCHIP_SKIP_SET_WAKE flag for dummy_irq_chip"). Signed-off-by: Geert Uytterhoeven Cc: Roger Quadros Cc: Gregory Clement Link: http://lkml.kernel.org/r/1432281529-23325-1-git-send-email-geert%2Brenesas@glider.be Signed-off-by: Thomas Gleixner --- kernel/irq/dummychip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c index 988dc58..6a54193 100644 --- a/kernel/irq/dummychip.c +++ b/kernel/irq/dummychip.c @@ -42,6 +42,7 @@ struct irq_chip no_irq_chip = { .irq_enable = noop, .irq_disable = noop, .irq_ack = ack_bad, + .flags = IRQCHIP_SKIP_SET_WAKE, }; /*