public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Fix typo in intel cache size
@ 2009-11-10 20:01 Dave Jones
  2009-11-10 20:53 ` Ingo Molnar
  2009-11-10 20:55 ` [tip:x86/urgent] x86: Fix typo in Intel CPU cache size descriptor tip-bot for Dave Jones
  0 siblings, 2 replies; 3+ messages in thread
From: Dave Jones @ 2009-11-10 20:01 UTC (permalink / raw)
  To: x86; +Cc: Linux Kernel

I double-checked the datasheet. This should be 2MB.

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 804c40e..6123138 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -94,7 +94,7 @@ static const struct _cache_table __cpuinitconst cache_table[] =
 	{ 0xd1, LVL_3,    1024 },	/* 4-way set assoc, 64 byte line size */
 	{ 0xd2, LVL_3,    2048 },	/* 4-way set assoc, 64 byte line size */
 	{ 0xd6, LVL_3,    1024 },	/* 8-way set assoc, 64 byte line size */
-	{ 0xd7, LVL_3,    2038 },	/* 8-way set assoc, 64 byte line size */
+	{ 0xd7, LVL_3,    2048 },	/* 8-way set assoc, 64 byte line size */
 	{ 0xd8, LVL_3,    4096 },	/* 12-way set assoc, 64 byte line size */
 	{ 0xdc, LVL_3,    2048 },	/* 12-way set assoc, 64 byte line size */
 	{ 0xdd, LVL_3,    4096 },	/* 12-way set assoc, 64 byte line size */

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Fix typo in intel cache size
  2009-11-10 20:01 Fix typo in intel cache size Dave Jones
@ 2009-11-10 20:53 ` Ingo Molnar
  2009-11-10 20:55 ` [tip:x86/urgent] x86: Fix typo in Intel CPU cache size descriptor tip-bot for Dave Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-11-10 20:53 UTC (permalink / raw)
  To: Dave Jones, x86, Linux Kernel


* Dave Jones <davej@redhat.com> wrote:

> I double-checked the datasheet. This should be 2MB.
> 
> Signed-off-by: Dave Jones <davej@redhat.com>
> 
> diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
> index 804c40e..6123138 100644
> --- a/arch/x86/kernel/cpu/intel_cacheinfo.c
> +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
> @@ -94,7 +94,7 @@ static const struct _cache_table __cpuinitconst cache_table[] =
>  	{ 0xd1, LVL_3,    1024 },	/* 4-way set assoc, 64 byte line size */
>  	{ 0xd2, LVL_3,    2048 },	/* 4-way set assoc, 64 byte line size */
>  	{ 0xd6, LVL_3,    1024 },	/* 8-way set assoc, 64 byte line size */
> -	{ 0xd7, LVL_3,    2038 },	/* 8-way set assoc, 64 byte line size */
> +	{ 0xd7, LVL_3,    2048 },	/* 8-way set assoc, 64 byte line size */

ah, thanks - applied.

I also marked both fixes from you for -stable backport - these are 
pretty risk-free fixes and cpuinfo looks ugly on new CPUs without a 
proper cache size entry.

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:x86/urgent] x86: Fix typo in Intel CPU cache size descriptor
  2009-11-10 20:01 Fix typo in intel cache size Dave Jones
  2009-11-10 20:53 ` Ingo Molnar
@ 2009-11-10 20:55 ` tip-bot for Dave Jones
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Dave Jones @ 2009-11-10 20:55 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, davej, tglx, mingo

Commit-ID:  e02e0e1a130b9ca37c5186d38ad4b3aaf58bb149
Gitweb:     http://git.kernel.org/tip/e02e0e1a130b9ca37c5186d38ad4b3aaf58bb149
Author:     Dave Jones <davej@redhat.com>
AuthorDate: Tue, 10 Nov 2009 15:01:20 -0500
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 10 Nov 2009 21:52:32 +0100

x86: Fix typo in Intel CPU cache size descriptor

I double-checked the datasheet. One of the existing
descriptors has a typo: it should be 2MB not 2038 KB.

Signed-off-by: Dave Jones <davej@redhat.com>
Cc: <stable@kernel.org> # .3x.x: 85160b9: x86: Add new Intel CPU cache size descriptors
Cc: <stable@kernel.org> # .3x.x
LKML-Reference: <20091110200120.GA27090@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/cpu/intel_cacheinfo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 1410392..8178d03 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -94,7 +94,7 @@ static const struct _cache_table __cpuinitconst cache_table[] =
 	{ 0xd1, LVL_3,    1024 },	/* 4-way set assoc, 64 byte line size */
 	{ 0xd2, LVL_3,    2048 },	/* 4-way set assoc, 64 byte line size */
 	{ 0xd6, LVL_3,    1024 },	/* 8-way set assoc, 64 byte line size */
-	{ 0xd7, LVL_3,    2038 },	/* 8-way set assoc, 64 byte line size */
+	{ 0xd7, LVL_3,    2048 },	/* 8-way set assoc, 64 byte line size */
 	{ 0xd8, LVL_3,    4096 },	/* 12-way set assoc, 64 byte line size */
 	{ 0xdc, LVL_3,    2048 },	/* 12-way set assoc, 64 byte line size */
 	{ 0xdd, LVL_3,    4096 },	/* 12-way set assoc, 64 byte line size */

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-11-10 20:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-10 20:01 Fix typo in intel cache size Dave Jones
2009-11-10 20:53 ` Ingo Molnar
2009-11-10 20:55 ` [tip:x86/urgent] x86: Fix typo in Intel CPU cache size descriptor tip-bot for Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox