From: tip-bot for Byungchul Park <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: peterz@infradead.org, torvalds@linux-foundation.org,
mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com,
byungchul.park@lge.com, linux-kernel@vger.kernel.org
Subject: [tip:locking/core] locking/lockdep: Introduce CONFIG_BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK=y
Date: Wed, 25 Oct 2017 04:12:35 -0700 [thread overview]
Message-ID: <tip-e121d64e16484d4a5eba94cd2fa9eb3848b7c9c2@git.kernel.org> (raw)
In-Reply-To: <1508921765-15396-7-git-send-email-byungchul.park@lge.com>
Commit-ID: e121d64e16484d4a5eba94cd2fa9eb3848b7c9c2
Gitweb: https://git.kernel.org/tip/e121d64e16484d4a5eba94cd2fa9eb3848b7c9c2
Author: Byungchul Park <byungchul.park@lge.com>
AuthorDate: Wed, 25 Oct 2017 17:56:02 +0900
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 25 Oct 2017 12:19:02 +0200
locking/lockdep: Introduce CONFIG_BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK=y
Add a Kconfig knob that enables the lockdep "crossrelease_fullstack" boot parameter.
Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: amir73il@gmail.com
Cc: axboe@kernel.dk
Cc: darrick.wong@oracle.com
Cc: david@fromorbit.com
Cc: hch@infradead.org
Cc: idryomov@gmail.com
Cc: johan@kernel.org
Cc: johannes.berg@intel.com
Cc: kernel-team@lge.com
Cc: linux-block@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org
Cc: linux-xfs@vger.kernel.org
Cc: oleg@redhat.com
Cc: tj@kernel.org
Link: http://lkml.kernel.org/r/1508921765-15396-7-git-send-email-byungchul.park@lge.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/locking/lockdep.c | 4 ++++
lib/Kconfig.debug | 15 +++++++++++++++
2 files changed, 19 insertions(+)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 160b5d6..db933d0 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -76,7 +76,11 @@ module_param(lock_stat, int, 0644);
#define lock_stat 0
#endif
+#ifdef CONFIG_BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK
+static int crossrelease_fullstack = 1;
+#else
static int crossrelease_fullstack;
+#endif
static int __init allow_crossrelease_fullstack(char *str)
{
crossrelease_fullstack = 1;
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index c1e720a..2b439a5 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1179,6 +1179,21 @@ config LOCKDEP_COMPLETIONS
A deadlock caused by wait_for_completion() and complete() can be
detected by lockdep using crossrelease feature.
+config BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK
+ bool "Enable the boot parameter, crossrelease_fullstack"
+ depends on LOCKDEP_CROSSRELEASE
+ default n
+ help
+ The lockdep "cross-release" feature needs to record stack traces
+ (of calling functions) for all acquisitions, for eventual later
+ use during analysis. By default only a single caller is recorded,
+ because the unwind operation can be very expensive with deeper
+ stack chains.
+
+ However a boot parameter, crossrelease_fullstack, was
+ introduced since sometimes deeper traces are required for full
+ analysis. This option turns on the boot parameter.
+
config DEBUG_LOCKDEP
bool "Lock dependency engine debugging"
depends on DEBUG_KERNEL && LOCKDEP
next prev parent reply other threads:[~2017-10-25 11:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 8:55 [PATCH v5 0/9] cross-release: Enhence performance and fix false positives Byungchul Park
2017-10-25 8:55 ` [PATCH v5 1/9] block: use DECLARE_COMPLETION_ONSTACK in submit_bio_wait Byungchul Park
2017-10-25 11:10 ` [tip:locking/core] block: Use DECLARE_COMPLETION_ONSTACK() in submit_bio_wait() tip-bot for Christoph Hellwig
2017-10-25 8:55 ` [PATCH v5 2/9] locking/lockdep: Provide empty lockdep_map structure for !CONFIG_LOCKDEP Byungchul Park
2017-10-25 11:11 ` [tip:locking/core] " tip-bot for Byungchul Park
2017-10-25 8:55 ` [PATCH v5 3/9] completion: Change the prefix of lock name for completion variable Byungchul Park
2017-10-25 11:11 ` [tip:locking/core] locking/lockdep, sched/completions: Change the prefix of lock name for completion variables tip-bot for Byungchul Park
2017-10-25 8:56 ` [PATCH v5 4/9] locking/lockdep: Add a boot parameter allowing unwind in cross-release and disable it by default Byungchul Park
2017-10-25 11:11 ` [tip:locking/core] " tip-bot for Byungchul Park
2017-10-25 8:56 ` [PATCH v5 5/9] locking/lockdep: Remove the BROKEN flag from CONFIG_LOCKDEP_CROSSRELEASE and CONFIG_LOCKDEP_COMPLETIONS Byungchul Park
2017-10-25 11:12 ` [tip:locking/core] " tip-bot for Byungchul Park
2017-10-25 8:56 ` [PATCH v5 6/9] locking/lockdep: Introduce CONFIG_BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK Byungchul Park
2017-10-25 11:12 ` tip-bot for Byungchul Park [this message]
2017-10-25 8:56 ` [PATCH v5 7/9] completion: Add support for initializing completion with lockdep_map Byungchul Park
2017-10-25 11:12 ` [tip:locking/core] sched/completions: Add support for initializing completions " tip-bot for Byungchul Park
2017-10-25 8:56 ` [PATCH v5 8/9] workqueue: Remove unnecessary acquisitions wrt workqueue flush Byungchul Park
2017-10-25 11:13 ` [tip:locking/core] workqueue: Remove now redundant lock acquisitions wrt. workqueue flushes tip-bot for Byungchul Park
2017-10-25 8:56 ` [PATCH v5 9/9] block: Assign a lock_class per gendisk used for wait_for_completion() Byungchul Park
2017-10-25 10:13 ` Ingo Molnar
2017-10-25 18:20 ` Jens Axboe
2017-10-26 5:50 ` Ingo Molnar
2017-10-26 5:58 ` Byungchul Park
2017-10-26 9:31 ` [tip:locking/core] block, locking/lockdep: " tip-bot for Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-e121d64e16484d4a5eba94cd2fa9eb3848b7c9c2@git.kernel.org \
--to=tipbot@zytor.com \
--cc=byungchul.park@lge.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox