From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932787AbcCCQyK (ORCPT ); Thu, 3 Mar 2016 11:54:10 -0500 Received: from torg.zytor.com ([198.137.202.12]:48402 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932728AbcCCQyD (ORCPT ); Thu, 3 Mar 2016 11:54:03 -0500 Date: Thu, 3 Mar 2016 08:52:28 -0800 From: tip-bot for Josh Poimboeuf Message-ID: Cc: peterz@infradead.org, torvalds@linux-foundation.org, jpoimboe@redhat.com, hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com, mingo@kernel.org, akpm@linux-foundation.org, jolsa@kernel.org, sfr@canb.auug.org.au Reply-To: jpoimboe@redhat.com, torvalds@linux-foundation.org, peterz@infradead.org, sfr@canb.auug.org.au, jolsa@kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sudipm.mukherjee@gmail.com, mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de In-Reply-To: <94a078c6c998fac9f01a14f574008bf7dff40191.1457016803.git.jpoimboe@redhat.com> References: <94a078c6c998fac9f01a14f574008bf7dff40191.1457016803.git.jpoimboe@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:core/objtool] tools: Support relative directory path for 'O=' Git-Commit-ID: e17cf3a80d4ba0c4e40bf1a89deb1354c2e10e14 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: e17cf3a80d4ba0c4e40bf1a89deb1354c2e10e14 Gitweb: http://git.kernel.org/tip/e17cf3a80d4ba0c4e40bf1a89deb1354c2e10e14 Author: Josh Poimboeuf AuthorDate: Thu, 3 Mar 2016 08:53:43 -0600 Committer: Ingo Molnar CommitDate: Thu, 3 Mar 2016 16:13:00 +0100 tools: Support relative directory path for 'O=' Running "make O=foo" (with a relative directory path) fails with: scripts/Makefile.include:3: *** O=foo does not exist. Stop. /home/jpoimboe/git/linux/Makefile:1547: recipe for target 'tools/objtool' failed The tools Makefile gets confused by the relative path and tries to build objtool in tools/foo. Convert the output directory to an absolute path before passing it to the tools Makefile. Reported-by: Sudip Mukherjee Signed-off-by: Josh Poimboeuf Cc: Andrew Morton Cc: Jiri Olsa Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Stephen Rothwell Cc: Thomas Gleixner Cc: linux-next@vger.kernel.org Cc: linux@roeck-us.net Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/94a078c6c998fac9f01a14f574008bf7dff40191.1457016803.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 62be03b..2c27a01 100644 --- a/Makefile +++ b/Makefile @@ -1509,11 +1509,11 @@ image_name: # Clear a bunch of variables before executing the submake tools/: FORCE $(Q)mkdir -p $(objtree)/tools - $(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(O) subdir=tools -C $(src)/tools/ + $(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(shell cd $(objtree) && /bin/pwd) subdir=tools -C $(src)/tools/ tools/%: FORCE $(Q)mkdir -p $(objtree)/tools - $(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(O) subdir=tools -C $(src)/tools/ $* + $(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(shell cd $(objtree) && /bin/pwd) subdir=tools -C $(src)/tools/ $* # Single targets # ---------------------------------------------------------------------------