From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753296AbbCAQuf (ORCPT ); Sun, 1 Mar 2015 11:50:35 -0500 Received: from terminus.zytor.com ([198.137.202.10]:60230 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbbCAQuN (ORCPT ); Sun, 1 Mar 2015 11:50:13 -0500 Date: Sun, 1 Mar 2015 08:49:26 -0800 From: tip-bot for Bruce Merry Message-ID: Cc: hpa@zytor.com, acme@redhat.com, paulus@samba.org, bmerry@ska.ac.za, peterz@infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org Reply-To: peterz@infradead.org, paulus@samba.org, acme@redhat.com, bmerry@ska.ac.za, hpa@zytor.com, mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org In-Reply-To: <20150115092022.GA11292@kryton> References: <20150115092022.GA11292@kryton> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf bench: Fix order of arguments to memcpy_alloc_mem Git-Commit-ID: e17fdaeaec066c725f73cd3cda1feae52b2646f5 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: e17fdaeaec066c725f73cd3cda1feae52b2646f5 Gitweb: http://git.kernel.org/tip/e17fdaeaec066c725f73cd3cda1feae52b2646f5 Author: Bruce Merry AuthorDate: Thu, 15 Jan 2015 11:20:22 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Sun, 22 Feb 2015 23:10:56 -0300 perf bench: Fix order of arguments to memcpy_alloc_mem This was causing the destination instead of the source to be filled. As a result, the source was typically all mapped to one zero page, and hence very cacheable. Signed-off-by: Bruce Merry Acked-by: Ingo Molnar Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20150115092022.GA11292@kryton Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/bench/mem-memcpy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c index 6c14afe..db1d3a2 100644 --- a/tools/perf/bench/mem-memcpy.c +++ b/tools/perf/bench/mem-memcpy.c @@ -289,7 +289,7 @@ static u64 do_memcpy_cycle(const struct routine *r, size_t len, bool prefault) memcpy_t fn = r->fn.memcpy; int i; - memcpy_alloc_mem(&src, &dst, len); + memcpy_alloc_mem(&dst, &src, len); if (prefault) fn(dst, src, len); @@ -312,7 +312,7 @@ static double do_memcpy_gettimeofday(const struct routine *r, size_t len, void *src = NULL, *dst = NULL; int i; - memcpy_alloc_mem(&src, &dst, len); + memcpy_alloc_mem(&dst, &src, len); if (prefault) fn(dst, src, len);