public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clocksource: mmio: remove artificial 32bit limitation
@ 2015-12-10 17:21 Linus Walleij
  2015-12-10 18:40 ` [tip:timers/urgent] clocksource: Mmio: " tip-bot for Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2015-12-10 17:21 UTC (permalink / raw)
  To: Daniel Lezcano, Thomas Gleixner
  Cc: linux-kernel, Alexander Sverdlin, Linus Walleij

The EP93xx is registering a clocksource of 40 bits with
clocksource_mmio_init() but this is not working because of this
artificial limitation. It works fine to lift the uppe limit to
64 bits, and since cycle_t is u64, it should intuitively have been
like that from the beginning.

Fixes: 000bc17817bf "ARM: ep93xx: switch to GENERIC_CLOCKEVENTS"
Reported-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/clocksource/mmio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/mmio.c b/drivers/clocksource/mmio.c
index 1593ade2a815..c4f7d7a9b689 100644
--- a/drivers/clocksource/mmio.c
+++ b/drivers/clocksource/mmio.c
@@ -55,7 +55,7 @@ int __init clocksource_mmio_init(void __iomem *base, const char *name,
 {
 	struct clocksource_mmio *cs;
 
-	if (bits > 32 || bits < 16)
+	if (bits > 64 || bits < 16)
 		return -EINVAL;
 
 	cs = kzalloc(sizeof(struct clocksource_mmio), GFP_KERNEL);
-- 
2.4.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:timers/urgent] clocksource: Mmio: remove artificial 32bit limitation
  2015-12-10 17:21 [PATCH] clocksource: mmio: remove artificial 32bit limitation Linus Walleij
@ 2015-12-10 18:40 ` tip-bot for Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Linus Walleij @ 2015-12-10 18:40 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linus.walleij, linux-kernel, alexander.sverdlin, daniel.lezcano,
	hpa, tglx, mingo

Commit-ID:  e2bf3e6ecaff79c5479682da2dc7b2035e52c5b8
Gitweb:     http://git.kernel.org/tip/e2bf3e6ecaff79c5479682da2dc7b2035e52c5b8
Author:     Linus Walleij <linus.walleij@linaro.org>
AuthorDate: Thu, 10 Dec 2015 18:21:41 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 10 Dec 2015 19:37:18 +0100

clocksource: Mmio: remove artificial 32bit limitation

The EP93xx is registering a clocksource of 40 bits with
clocksource_mmio_init() but this is not working because of this
artificial limitation. It works fine to lift the uppe limit to
64 bits, and since cycle_t is u64, it should intuitively have been
like that from the beginning.

Fixes: 000bc17817bf "ARM: ep93xx: switch to GENERIC_CLOCKEVENTS"
Reported-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: http://lkml.kernel.org/r/1449768101-6879-1-git-send-email-linus.walleij@linaro.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/clocksource/mmio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/mmio.c b/drivers/clocksource/mmio.c
index 1593ade..c4f7d7a 100644
--- a/drivers/clocksource/mmio.c
+++ b/drivers/clocksource/mmio.c
@@ -55,7 +55,7 @@ int __init clocksource_mmio_init(void __iomem *base, const char *name,
 {
 	struct clocksource_mmio *cs;
 
-	if (bits > 32 || bits < 16)
+	if (bits > 64 || bits < 16)
 		return -EINVAL;
 
 	cs = kzalloc(sizeof(struct clocksource_mmio), GFP_KERNEL);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-10 18:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-10 17:21 [PATCH] clocksource: mmio: remove artificial 32bit limitation Linus Walleij
2015-12-10 18:40 ` [tip:timers/urgent] clocksource: Mmio: " tip-bot for Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox