public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Steven Rostedt <srostedt@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	rostedt@goodmis.org, srostedt@redhat.com, tglx@linutronix.de,
	mingo@elte.hu
Subject: [tip:tracing/urgent] tracing: Fix return of trace_dump_stack()
Date: Tue, 15 Dec 2009 08:09:37 GMT	[thread overview]
Message-ID: <tip-e36c54582c6f14adc9e10473e2aec2cc4f0acc03@git.kernel.org> (raw)
In-Reply-To: <20091214162713.GA31060@elte.hu>

Commit-ID:  e36c54582c6f14adc9e10473e2aec2cc4f0acc03
Gitweb:     http://git.kernel.org/tip/e36c54582c6f14adc9e10473e2aec2cc4f0acc03
Author:     Steven Rostedt <srostedt@redhat.com>
AuthorDate: Mon, 14 Dec 2009 15:58:33 -0500
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 15 Dec 2009 08:36:11 +0100

tracing: Fix return of trace_dump_stack()

The trace_dump_stack() returned a value for a void function.

Also, added the missing stub for trace_dump_stack() when tracing is
not configured.

Reported-by: Ingo Molnar <mingo@elte.hu>
LKML-Reference: <20091214162713.GA31060@elte.hu>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/linux/kernel.h |    1 +
 kernel/trace/trace.c   |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 5ad4199..f1dc752 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -527,6 +527,7 @@ trace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 2)));
 static inline void tracing_start(void) { }
 static inline void tracing_stop(void) { }
 static inline void ftrace_off_permanent(void) { }
+static inline void trace_dump_stack(void) { }
 static inline int
 trace_printk(const char *fmt, ...)
 {
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index bd7b969..ee61915 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -1158,7 +1158,7 @@ void trace_dump_stack(void)
 	unsigned long flags;
 
 	if (tracing_disabled || tracing_selftest_running)
-		return 0;
+		return;
 
 	local_save_flags(flags);
 

      parent reply	other threads:[~2009-12-15  8:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 18:40 [PATCH 0/2] [GIT PULL] tracing: stack tracing Steven Rostedt
2009-12-11 18:40 ` [PATCH 1/2] [PATCH 1/2] tracing: Add trace_dump_stack() Steven Rostedt
2009-12-11 18:40 ` [PATCH 2/2] [PATCH 2/2] tracing: Add stack trace to irqsoff tracer Steven Rostedt
2009-12-14 16:12 ` [PATCH 0/2] [GIT PULL] tracing: stack tracing Ingo Molnar
2009-12-14 16:27   ` Ingo Molnar
2009-12-14 16:46     ` Steven Rostedt
2009-12-14 21:44     ` [PATCH][GIT PULL] tracing: Fix return of trace_dump_stack() Steven Rostedt
2009-12-15  7:34       ` Ingo Molnar
2009-12-15  8:09     ` tip-bot for Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-e36c54582c6f14adc9e10473e2aec2cc4f0acc03@git.kernel.org \
    --to=srostedt@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox