[PATCH] x86: memblock: move mem_hole_size() to .init

[PATCH] x86: memblock: move mem_hole_size() to .init

[Jiri Kosina]

mem_hole_size() is being called only from __init-marked functions, and as 
such should be moved to .init section as well. Fixes this warning:

WARNING: vmlinux.o(.text+0x35511): Section mismatch in reference from the function mem_hole_size() to the function .init.text:absent_pages_in_range()

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 arch/x86/mm/numa_emulation.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/numa_emulation.c b/arch/x86/mm/numa_emulation.c
index 46db568..2fff651 100644
--- a/arch/x86/mm/numa_emulation.c
+++ b/arch/x86/mm/numa_emulation.c
@@ -28,7 +28,7 @@ static int __init emu_find_memblk_by_nid(int nid, const struct numa_meminfo *mi)
 	return -ENOENT;
 }
 
-static u64 mem_hole_size(u64 start, u64 end)
+static u64 __init mem_hole_size(u64 start, u64 end)
 {
 	unsigned long start_pfn = PFN_UP(start);
 	unsigned long end_pfn = PFN_DOWN(end);
-- 
1.7.3.1

Re: [PATCH] x86: memblock: move mem_hole_size() to .init

[Tejun Heo]

On Tue, Feb 28, 2012 at 04:16:33PM +0100, Jiri Kosina wrote:
> mem_hole_size() is being called only from __init-marked functions, and as 
> such should be moved to .init section as well. Fixes this warning:
> 
> WARNING: vmlinux.o(.text+0x35511): Section mismatch in reference from the function mem_hole_size() to the function .init.text:absent_pages_in_range()
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Re: [PATCH] x86: memblock: move mem_hole_size() to .init

[Jiri Kosina]

On Wed, 29 Feb 2012, Tejun Heo wrote:

> > mem_hole_size() is being called only from __init-marked functions, and as 
> > such should be moved to .init section as well. Fixes this warning:
> > 
> > WARNING: vmlinux.o(.text+0x35511): Section mismatch in reference from the function mem_hole_size() to the function .init.text:absent_pages_in_range()
> > 
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> 
> Acked-by: Tejun Heo <tj@kernel.org>

Thanks. Doesn't seem to have been picked up ... Ingo/hpa, I guess it's 
appropriate for -tip?

-- 
Jiri Kosina
SUSE Labs

[tip:x86/urgent] x86, memblock: Move mem_hole_size() to .init

[tip-bot for Jiri Kosina]

Commit-ID:  e37aade31601cdb9f078f6663cbf887f391bb110
Gitweb:     http://git.kernel.org/tip/e37aade31601cdb9f078f6663cbf887f391bb110
Author:     Jiri Kosina <jkosina@suse.cz>
AuthorDate: Tue, 28 Feb 2012 16:16:33 +0100
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Sat, 3 Mar 2012 15:51:20 -0800

x86, memblock: Move mem_hole_size() to .init

mem_hole_size() is being called only from __init-marked functions, and as
such should be moved to .init section as well. Fixes this warning:

WARNING: vmlinux.o(.text+0x35511): Section mismatch in reference from the function mem_hole_size() to the function .init.text:absent_pages_in_range()

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Link: http://lkml.kernel.org/r/alpine.LNX.2.00.1202281614450.31150@pobox.suse.cz
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/mm/numa_emulation.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/numa_emulation.c b/arch/x86/mm/numa_emulation.c
index 46db568..2fff651 100644
--- a/arch/x86/mm/numa_emulation.c
+++ b/arch/x86/mm/numa_emulation.c
@@ -28,7 +28,7 @@ static int __init emu_find_memblk_by_nid(int nid, const struct numa_meminfo *mi)
 	return -ENOENT;
 }
 
-static u64 mem_hole_size(u64 start, u64 end)
+static u64 __init mem_hole_size(u64 start, u64 end)
 {
 	unsigned long start_pfn = PFN_UP(start);
 	unsigned long end_pfn = PFN_DOWN(end);