[PATCHv2] Support for perf on AMD family17h processors

[PATCHv2] Support for perf on AMD family17h processors

[Janakarajan Natarajan]

This patch enables perf core PMU support for AMD family17h processors. In
family17h, there is no PMC-event constraint. All events, irrespective of
the type, can be measured using any of the performance counters.

Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
---

v1->v2

* Removed renaming of amd_core_pmu_init and associated comment.
* Changed comment style to follow guidelines.

 arch/x86/events/amd/core.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index f5f4b3f..afb222b 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -662,7 +662,13 @@ static int __init amd_core_pmu_init(void)
 		pr_cont("Fam15h ");
 		x86_pmu.get_event_constraints = amd_get_event_constraints_f15h;
 		break;
-
+	case 0x17:
+		pr_cont("Fam17h ");
+		/*
+		 * In family 17h, there are no event constraints in the PMC hardware.
+		 * We fallback to using default amd_get_event_constraints.
+		 */
+		break;
 	default:
 		pr_err("core perfctr but no constraints; unknown hardware!\n");
 		return -ENODEV;
-- 
2.7.4

Re: [PATCHv2] Support for perf on AMD family17h processors

[Borislav Petkov]

On Thu, Nov 17, 2016 at 10:15:06AM -0600, Janakarajan Natarajan wrote:
> This patch enables perf core PMU support for AMD family17h processors. In
> family17h, there is no PMC-event constraint. All events, irrespective of
> the type, can be measured using any of the performance counters.
> 
> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
> ---
> 
> v1->v2
> 
> * Removed renaming of amd_core_pmu_init and associated comment.
> * Changed comment style to follow guidelines.
> 
>  arch/x86/events/amd/core.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

I already ran your previous one today and since this one doesn't bring
any changes which matter:

Acked-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

[tip:perf/urgent] perf/x86: Add perf support for AMD family-17h processors

[tip-bot for Janakarajan Natarajan]

Commit-ID:  e40ed1542dd779e5037a22c6b534e57127472365
Gitweb:     http://git.kernel.org/tip/e40ed1542dd779e5037a22c6b534e57127472365
Author:     Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
AuthorDate: Thu, 17 Nov 2016 10:15:06 -0600
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 18 Nov 2016 09:45:57 +0100

perf/x86: Add perf support for AMD family-17h processors

This patch enables perf core PMU support for the new AMD family-17h processors.

In family-17h, there is no PMC-event constraint. All events, irrespective of
the type, can be measured using any of the six generic performance counters.

Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
Acked-by: Borislav Petkov <bp@suse.de>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/1479399306-13375-1-git-send-email-Janakarajan.Natarajan@amd.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/events/amd/core.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index f5f4b3f..afb222b 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -662,7 +662,13 @@ static int __init amd_core_pmu_init(void)
 		pr_cont("Fam15h ");
 		x86_pmu.get_event_constraints = amd_get_event_constraints_f15h;
 		break;
-
+	case 0x17:
+		pr_cont("Fam17h ");
+		/*
+		 * In family 17h, there are no event constraints in the PMC hardware.
+		 * We fallback to using default amd_get_event_constraints.
+		 */
+		break;
 	default:
 		pr_err("core perfctr but no constraints; unknown hardware!\n");
 		return -ENODEV;