Re: [PATCH 12/21] cpufreq: Convert to hotplug state machine

Sebastian Andrzej Siewior
2016-09-07T14:18:40Z

On 2016-09-06 23:27:46 [+0200], Rafael J. Wysocki wrote:
> > + ret = cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, "cpufreq:online",
> > + cpufreq_online,
> > + cpufreq_offline);
> > + if (ret < 0)
> > + goto err_if_unreg;
> > + hp_online = ret;
>
> hp_online is enum cpuhp_state (and we pass it to
> cpuhp_remove_state_nocalls(() later on), but
> cpuhp_setup_state_nocalls() returns an int (and that should be 0 if it
> is not an error code AFAICS), so is this actually correct?

Not sure what you are pointing out here. Let me try to cover it.
cpuhp_setup_state_nocalls() return <0 for errors. Those are are not
assigned to hp_online. It returns 0 for success on ID was !=
CPUHP_AP_ONLINE_DYN and >= 0 for success if ID was CPUHP_AP_ONLINE_DYN.
In the latter case the dynamic assigned ID is returned which should be
used if you plan to remove the callbacks.
Assigning an unsigned int to enum is okay because enumeration constants
itself should be an int.

> Thanks,
> Rafael

Sebastian