Re: [tip:smp/hotplug] cpufreq: Fix up conversion to hotplug state machine

Borislav Petkov
2016-09-20T16:09:04Z

On Tue, Sep 20, 2016 at 08:07:08AM -0700, tip-bot for Sebastian Andrzej Siewior wrote:
> Commit-ID: 5372e054a1928fe704cf0a5e2e139645a777b50a
> Gitweb: http://git.kernel.org/tip/5372e054a1928fe704cf0a5e2e139645a777b50a
> Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> AuthorDate: Tue, 20 Sep 2016 16:56:28 +0200
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Tue, 20 Sep 2016 16:59:21 +0200
>
> cpufreq: Fix up conversion to hotplug state machine
>
> The function cpufreq_register_driver() returns zero on success and since
> commit 27622b061eb4 ("cpufreq: Convert to hotplug state machine")
> erroneously a positive number. Due to the "if (x) assume_error" construct
> all callers assumed an error and as a consequence the cpu freq kworker
> crashes with a NULL pointer dereference.
>
> Reset the return value back to zero in the success case.
>
> Fixes: 27622b061eb4 ("cpufreq: Convert to hotplug state machine")
> Reported-by: Borislav Petkov <bp@alien8.de>

-and-tested-by: me.

Thanks!

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.