From: tip-bot for Steffen Persvold <sp@numascale.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
sp@numascale.com, jbarnes@virtuousgeek.org, tglx@linutronix.de,
daniel@numascale-asia.com, mingo@elte.hu
Subject: [tip:x86/apic] x86: Fix the !CONFIG_NUMA build of the new CPU ID fixup code support
Date: Mon, 5 Dec 2011 22:30:35 -0800 [thread overview]
Message-ID: <tip-e4a02b4a951a7adf9d982b11c64686570c29fbe7@git.kernel.org> (raw)
In-Reply-To: <1323073238-32686-2-git-send-email-daniel@numascale-asia.com>
Commit-ID: e4a02b4a951a7adf9d982b11c64686570c29fbe7
Gitweb: http://git.kernel.org/tip/e4a02b4a951a7adf9d982b11c64686570c29fbe7
Author: Steffen Persvold <sp@numascale.com>
AuthorDate: Tue, 6 Dec 2011 01:10:31 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 6 Dec 2011 07:03:37 +0100
x86: Fix the !CONFIG_NUMA build of the new CPU ID fixup code support
I used "ifdef CONFIG_NUMA" simply because it doesn't make
sense in a non-numa configuration even with SMP enabled.
Besides, the only place where it is called right now is
in kernel/cpu/amd.c:srat_detect_node() within the
"CONFIG_NUMA" protected part.
Signed-off-by: Steffen Persvold <sp@numascale.com>
Cc: Daniel J Blueman <daniel@numascale-asia.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Link: http://lkml.kernel.org/r/1323073238-32686-2-git-send-email-daniel@numascale-asia.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/cpu/common.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index ad4da45..a70bd5b 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -1146,7 +1146,9 @@ static void dbg_restore_debug_regs(void)
*/
void __cpuinit x86_default_fixup_cpu_id(struct cpuinfo_x86 *c, int node)
{
+#ifdef CONFIG_NUMA
pr_err("NUMA core number %d differs from configured core number %d\n", node, c->phys_proc_id);
+#endif
}
/*
next prev parent reply other threads:[~2011-12-06 6:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 6:07 [PATCH 1/3] Add Numachip APIC support Daniel J Blueman
2011-10-26 6:07 ` [PATCH 2/3] Add multi-node boot support Daniel J Blueman
2011-10-27 7:30 ` Ingo Molnar
2011-10-27 10:46 ` Steffen Persvold
2011-10-27 11:38 ` Ingo Molnar
2011-10-27 11:42 ` Steffen Persvold
2011-12-02 18:31 ` Daniel J Blueman
2011-12-05 8:20 ` [PATCH 1/3] Make flat_init_apic_ldr available Daniel J Blueman
2011-12-05 8:20 ` [PATCH 2/3] v2: Add x86_init platform override to fix up core numbering Daniel J Blueman
2011-12-05 17:58 ` [tip:x86/apic] x86: Add x86_init platform override to fix up NUMA " tip-bot for Daniel J Blueman
2011-12-06 6:30 ` tip-bot for Steffen Persvold [this message]
2011-12-05 8:20 ` [PATCH 3/3] v4: Add support for Numascale's NumaChip Daniel J Blueman
2011-12-05 9:10 ` Ingo Molnar
2011-12-05 9:49 ` Steffen Persvold
2011-12-05 16:07 ` [PATCH 3/3] v5: Add NumaChip support Daniel J Blueman
2011-12-05 17:59 ` [tip:x86/apic] x86: " tip-bot for Steffen Persvold
2011-12-05 20:31 ` Ingo Molnar
2011-12-06 0:10 ` Steffen Persvold
2011-12-06 5:50 ` Ingo Molnar
2011-12-06 6:09 ` Steffen Persvold
2011-12-08 22:35 ` Kevin Winchester
2011-12-09 1:24 ` Steffen Persvold
2011-12-09 7:22 ` Ingo Molnar
2011-12-10 1:52 ` Kevin Winchester
2011-12-10 2:28 ` Kevin Winchester
2011-12-18 9:44 ` Ingo Molnar
2011-12-19 0:12 ` [PATCH] x86: Simplify code by allowing more of struct cpuinfo_x86 for the !SMP case Kevin Winchester
2011-12-19 14:07 ` [tip:x86/apic] " tip-bot for Kevin Winchester
2011-12-19 18:47 ` Ingo Molnar
2011-12-21 0:52 ` [PATCH] " Kevin Winchester
2011-12-21 8:48 ` [tip:x86/apic] x86: Simplify code by removing a !SMP #ifdefs from 'struct cpuinfo_x86' tip-bot for Kevin Winchester
2011-12-05 17:57 ` [tip:x86/apic] x86: Make flat_init_apic_ldr() available tip-bot for Daniel J Blueman
2011-10-26 6:07 ` [PATCH 3/3] Add NumaChip quirk Daniel J Blueman
2011-10-27 7:26 ` [PATCH 1/3] Add Numachip APIC support Ingo Molnar
2011-10-27 7:35 ` Ingo Molnar
2011-10-27 7:44 ` Ingo Molnar
2011-10-27 10:31 ` Steffen Persvold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-e4a02b4a951a7adf9d982b11c64686570c29fbe7@git.kernel.org \
--to=sp@numascale.com \
--cc=daniel@numascale-asia.com \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).