From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, paulus@samba.org,
hpa@zytor.com, mingo@kernel.org, a.p.zijlstra@chello.nl,
namhyung@kernel.org, jolsa@redhat.com, fweisbec@gmail.com,
dsahern@gmail.com, tglx@linutronix.de, oleg@redhat.com,
cjashfor@linux.vnet.ibm.com, mingo@elte.hu
Subject: [tip:perf/urgent] perf record: Fix -C option
Date: Mon, 18 Mar 2013 03:53:43 -0700 [thread overview]
Message-ID: <tip-e4dd45fe7add0de09e0e5b2b511732d9c86b6ee7@git.kernel.org> (raw)
In-Reply-To: <1361785972-7431-2-git-send-email-jolsa@redhat.com>
Commit-ID: e4dd45fe7add0de09e0e5b2b511732d9c86b6ee7
Gitweb: http://git.kernel.org/tip/e4dd45fe7add0de09e0e5b2b511732d9c86b6ee7
Author: Jiri Olsa <jolsa@redhat.com>
AuthorDate: Mon, 25 Feb 2013 10:52:48 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 13 Mar 2013 16:58:28 -0300
perf record: Fix -C option
Currently the -C option does not work for record command, because of the
targets mismatch when synthesizing threads.
Fixing this by using proper target interface for the synthesize
decision.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Reported-by: Oleg Nesterov <oleg@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1361785972-7431-2-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-record.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 774c907..f1a939e 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -573,13 +573,15 @@ static int __cmd_record(struct perf_record *rec, int argc, const char **argv)
perf_event__synthesize_guest_os, tool);
}
- if (!opts->target.system_wide)
+ if (perf_target__has_task(&opts->target))
err = perf_event__synthesize_thread_map(tool, evsel_list->threads,
process_synthesized_event,
machine);
- else
+ else if (perf_target__has_cpu(&opts->target))
err = perf_event__synthesize_threads(tool, process_synthesized_event,
machine);
+ else /* command specified */
+ err = 0;
if (err != 0)
goto out_delete_session;
next prev parent reply other threads:[~2013-03-18 10:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 9:52 [PATCH 0/5] perf tools: Fix -C option for record command Jiri Olsa
2013-02-25 9:52 ` [PATCH 1/5] " Jiri Olsa
2013-02-25 18:39 ` Oleg Nesterov
2013-02-25 18:56 ` David Ahern
2013-02-25 19:38 ` Jiri Olsa
2013-02-26 14:38 ` Oleg Nesterov
2013-03-18 10:53 ` tip-bot for Jiri Olsa [this message]
2013-02-25 9:52 ` [PATCH 2/5] perf tests: Make attr script verbose friendly Jiri Olsa
2013-03-21 10:54 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-02-25 9:52 ` [PATCH 3/5] perf tests: Make attr script test event cpu Jiri Olsa
2013-03-21 10:55 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-02-25 9:52 ` [PATCH 4/5] perf tests: Add attr record -C cpu test Jiri Olsa
2013-03-21 10:57 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-02-25 9:52 ` [PATCH 5/5] perf tests: Add attr stat " Jiri Olsa
2013-03-21 10:58 ` [tip:perf/core] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-e4dd45fe7add0de09e0e5b2b511732d9c86b6ee7@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox