From: tip-bot for Mike Galbraith <efault@gmx.de>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
peterz@infradead.org, efault@gmx.de, lennart@poettering.net,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/core] sched: Introduce SCHED_RESET_ON_FORK scheduling policy flag, fix
Date: Wed, 17 Jun 2009 10:32:17 GMT [thread overview]
Message-ID: <tip-e53438963eacc5624b61293f64e9f93c71f71198@git.kernel.org> (raw)
In-Reply-To: <1245143108.6038.10.camel@marge.simson.net>
Commit-ID: e53438963eacc5624b61293f64e9f93c71f71198
Gitweb: http://git.kernel.org/tip/e53438963eacc5624b61293f64e9f93c71f71198
Author: Mike Galbraith <efault@gmx.de>
AuthorDate: Tue, 16 Jun 2009 11:05:08 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 17 Jun 2009 09:01:51 +0200
sched: Introduce SCHED_RESET_ON_FORK scheduling policy flag, fix
Make SCHED_RESET_ON_FORK to DTRT for reniced tasks, and make the
sched_fork() SCHED_RESET_ON_FORK bits a self-contained unlikely
code block.
Signed-off-by: Mike Galbraith <efault@gmx.de>
Acked-by: Lennart Poettering <lennart@poettering.net>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <1245143108.6038.10.camel@marge.simson.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c | 41 ++++++++++++++++++++++++-----------------
1 file changed, 24 insertions(+), 17 deletions(-)
---
kernel/sched.c | 39 +++++++++++++++++++++++----------------
1 files changed, 23 insertions(+), 16 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 32e6ede..34f9424 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2613,28 +2613,35 @@ void sched_fork(struct task_struct *p, int clone_flags)
set_task_cpu(p, cpu);
/*
- * Revert to default priority/policy on fork if requested. Make sure we
- * do not leak PI boosting priority to the child.
+ * Make sure we do not leak PI boosting priority to the child.
*/
- if (current->sched_reset_on_fork &&
- (p->policy == SCHED_FIFO || p->policy == SCHED_RR))
- p->policy = SCHED_NORMAL;
+ p->prio = current->normal_prio;
- if (current->sched_reset_on_fork &&
- (current->normal_prio < DEFAULT_PRIO))
- p->prio = DEFAULT_PRIO;
- else
- p->prio = current->normal_prio;
+ /*
+ * Revert to default priority/policy on fork if requested.
+ */
+ if (unlikely(p->sched_reset_on_fork)) {
+ if (p->policy == SCHED_FIFO || p->policy == SCHED_RR)
+ p->policy = SCHED_NORMAL;
+
+ if (p->normal_prio < DEFAULT_PRIO)
+ p->prio = DEFAULT_PRIO;
+
+ if (PRIO_TO_NICE(p->static_prio) < 0) {
+ p->static_prio = NICE_TO_PRIO(0);
+ set_load_weight(p);
+ }
+
+ /*
+ * We don't need the reset flag anymore after the fork. It has
+ * fulfilled its duty:
+ */
+ p->sched_reset_on_fork = 0;
+ }
if (!rt_prio(p->prio))
p->sched_class = &fair_sched_class;
- /*
- * We don't need the reset flag anymore after the fork. It has
- * fulfilled its duty:
- */
- p->sched_reset_on_fork = 0;
-
#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
if (likely(sched_info_on()))
memset(&p->sched_info, 0, sizeof(p->sched_info));
prev parent reply other threads:[~2009-06-17 10:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 15:27 [PATCH] scheduler: introduce SCHED_RESET_ON_FORK scheduling policy flag, fourth try Lennart Poettering
2009-06-15 15:37 ` [tip:sched/core] sched: Introduce SCHED_RESET_ON_FORK scheduling policy flag tip-bot for Lennart Poettering
2009-06-16 9:05 ` [PATCH] scheduler: introduce SCHED_RESET_ON_FORK scheduling policy flag, fourth try Mike Galbraith
2009-06-16 16:47 ` Lennart Poettering
2009-06-17 8:46 ` [patch 1/2] " Mike Galbraith
2009-06-17 8:48 ` [patch 2/2] " Mike Galbraith
2009-06-17 16:36 ` [tip:sched/core] sched: Add SCHED_RESET_ON_FORK functionality for nice < 0 tasks tip-bot for Mike Galbraith
2009-06-17 16:36 ` [tip:sched/core] sched: Clean up SCHED_RESET_ON_FORK tip-bot for Mike Galbraith
2009-06-17 10:32 ` tip-bot for Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-e53438963eacc5624b61293f64e9f93c71f71198@git.kernel.org \
--to=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox