From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbdFCHfd (ORCPT ); Sat, 3 Jun 2017 03:35:33 -0400 Received: from terminus.zytor.com ([65.50.211.136]:51007 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbdFCHfb (ORCPT ); Sat, 3 Jun 2017 03:35:31 -0400 Date: Sat, 3 Jun 2017 00:34:13 -0700 From: tip-bot for Alexander Levin Message-ID: Cc: mingo@kernel.org, alexander.levin@verizon.com, hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org Reply-To: alexander.levin@verizon.com, mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org In-Reply-To: <20170603033903.12056-1-alexander.levin@verizon.com> References: <20170603033903.12056-1-alexander.levin@verizon.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:smp/hotplug] perf/core: Don't release cred_guard_mutex if not taken Git-Commit-ID: e5aeee51f6b4fb22e851105ee6d8ad211c40a214 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: e5aeee51f6b4fb22e851105ee6d8ad211c40a214 Gitweb: http://git.kernel.org/tip/e5aeee51f6b4fb22e851105ee6d8ad211c40a214 Author: Alexander Levin AuthorDate: Sat, 3 Jun 2017 03:39:13 +0000 Committer: Thomas Gleixner CommitDate: Sat, 3 Jun 2017 09:28:45 +0200 perf/core: Don't release cred_guard_mutex if not taken If we failed to acquire task's cred_guard_mutex we shouldn't proceed to release it in the error path. Fixes: a63fbed776c ("perf/tracing/cpuhotplug: Fix locking order") Signed-off-by: Alexander Levin Cc: peterz@infradead.org Cc: rostedt@goodmis.org Cc: mathieu.desnoyers@efficios.com Cc: mhiramat@kernel.org Cc: paulmck@linux.vnet.ibm.com Cc: bigeasy@linutronix.de Link: http://lkml.kernel.org/r/20170603033903.12056-1-alexander.levin@verizon.com Signed-off-by: Thomas Gleixner --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index b97cda4..1f1b8cd 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9878,7 +9878,7 @@ SYSCALL_DEFINE5(perf_event_open, if (task) { err = mutex_lock_interruptible(&task->signal->cred_guard_mutex); if (err) - goto err_cred; + goto err_task; /* * Reuse ptrace permission checks for now.