Re: [PATCH v2 0/7] perf ui/browser: Add browser for perf script

Namhyung Kim
2012-09-10T01:42:37Z

Hi Feng,

On Fri, 7 Sep 2012 16:42:22 +0800, Feng Tang wrote:
> Hi Arnaldo and all,
>
> This is a patch set mainly to add a browser for perf script, which
> will be integrated into the main hists and annotation browser.
>
> Patch 1-4 are some preparation for adding the script
> patch 5 introduce the script browser
> patch 6-7 integrate the browser to hists browser and annotation browser
>
> The patches are on top of current perf/core branch of your git tree.
> Please help to review.
>
> Namhyung,
>
> Many thanks for providing many good comments for the v1 patch sets. In
> this v2, I addressed most of those comments, for the suggestion to use
> browser for "perf script -l", I'll handle it later, and would post the
> v2 first for review.
>
> Changelog:
> Since v1:
> * Add filter for scripts can't be run in script browser
> * Fix some bugs about buffer handling and error check

For whole series,

Reviewed-by: Namhyung Kim <namhyung@kernel.org>

Thanks for your work!
Namhyung