[PATCH v2] perf/core: Fix updating cgroup time with descendants

[PATCH v2] perf/core: Fix updating cgroup time with descendants

[Lin Xiulei]

From: "leilei.lin" <leilei.lin@alibaba-inc.com>

This fix updating cgroup time when event is being scheduled in
by descendants

Signed-off-by: leilei.lin <leilei.lin@alibaba-inc.com>
Reviewed-and-tested-by: Jiri Olsa <jolsa@kernel.org>
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 3e691b7..e3a5e32 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -662,7 +662,7 @@ static inline void
update_cgrp_time_from_event(struct perf_event *event)
        /*
         * Do not update time when cgroup is not active
         */
-       if (cgrp == event->cgrp)
+       if (cgroup_is_descendant(cgrp->css.cgroup, event->cgrp->css.cgroup))
                __update_cgrp_time(event->cgrp);
 }

Re: [PATCH v2] perf/core: Fix updating cgroup time with descendants

[Peter Zijlstra]

On Fri, Sep 29, 2017 at 01:54:44PM +0800, Lin Xiulei wrote:
> From: "leilei.lin" <leilei.lin@alibaba-inc.com>
> 
> This fix updating cgroup time when event is being scheduled in
> by descendants
> 
> Signed-off-by: leilei.lin <leilei.lin@alibaba-inc.com>
> Reviewed-and-tested-by: Jiri Olsa <jolsa@kernel.org>

Thanks!

[tip:perf/urgent] perf/core: Fix cgroup time when scheduling descendants

[tip-bot for leilei.lin]

Commit-ID:  e6a5203399d19871021c1fa0eb2a08fc63b67e91
Gitweb:     https://git.kernel.org/tip/e6a5203399d19871021c1fa0eb2a08fc63b67e91
Author:     leilei.lin <leilei.lin@alibaba-inc.com>
AuthorDate: Fri, 29 Sep 2017 13:54:44 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 10 Oct 2017 10:06:55 +0200

perf/core: Fix cgroup time when scheduling descendants

Update cgroup time when an event is scheduled in by descendants.

Reviewed-and-tested-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: leilei.lin <leilei.lin@alibaba-inc.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: acme@kernel.org
Cc: alexander.shishkin@linux.intel.com
Cc: brendan.d.gregg@gmail.com
Cc: yang_oliver@hotmail.com
Link: http://lkml.kernel.org/r/CALPjY3mkHiekRkRECzMi9G-bjUQOvOjVBAqxmWkTzc-g+0LwMg@mail.gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 243bfc6..9d93db8 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -662,7 +662,7 @@ static inline void update_cgrp_time_from_event(struct perf_event *event)
 	/*
 	 * Do not update time when cgroup is not active
 	 */
-	if (cgrp == event->cgrp)
+       if (cgroup_is_descendant(cgrp->css.cgroup, event->cgrp->css.cgroup))
 		__update_cgrp_time(event->cgrp);
 }