From: tip-bot for Colin Ian King <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: torvalds@linux-foundation.org, bp@suse.de, tglx@linutronix.de,
colin.king@canonical.com, hpa@zytor.com, mingo@kernel.org,
peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: [tip:x86/urgent] x86/cpu/intel_cacheinfo: Remove redundant assignment to 'this_leaf'
Date: Mon, 16 Oct 2017 02:36:58 -0700 [thread overview]
Message-ID: <tip-e6fc454b7794fc45c27364c7896b8f03094635ee@git.kernel.org> (raw)
In-Reply-To: <20171015160203.12332-1-colin.king@canonical.com>
Commit-ID: e6fc454b7794fc45c27364c7896b8f03094635ee
Gitweb: https://git.kernel.org/tip/e6fc454b7794fc45c27364c7896b8f03094635ee
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Sun, 15 Oct 2017 17:02:03 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 16 Oct 2017 09:25:18 +0200
x86/cpu/intel_cacheinfo: Remove redundant assignment to 'this_leaf'
The 'this_leaf' variable is assigned a value that is never
read and it is updated a little later with a newer value,
hence we can remove the redundant assignment.
Cleans up the following Clang warning:
Value stored to 'this_leaf' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Borislav Petkov <bp@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/20171015160203.12332-1-colin.king@canonical.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/cpu/intel_cacheinfo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 24f74932..9990a71 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -831,7 +831,6 @@ static int __cache_amd_cpumap_setup(unsigned int cpu, int index,
} else if (boot_cpu_has(X86_FEATURE_TOPOEXT)) {
unsigned int apicid, nshared, first, last;
- this_leaf = this_cpu_ci->info_list + index;
nshared = base->eax.split.num_threads_sharing + 1;
apicid = cpu_data(cpu).apicid;
first = apicid - (apicid % nshared);
prev parent reply other threads:[~2017-10-16 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 16:02 [PATCH] x86/intel_cacheinfo: remove redundant assignment to this_leaf Colin King
2017-10-15 20:46 ` Borislav Petkov
2017-10-16 9:36 ` tip-bot for Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-e6fc454b7794fc45c27364c7896b8f03094635ee@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@suse.de \
--cc=colin.king@canonical.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox