Re: [PATCH] x86,vdso: fix the x86 vdso2c tool includes

Andy Lutomirski
2015-02-16T20:40:47Z

On Mon, Feb 16, 2015 at 8:50 AM, Tommi Kyntola <tommi.kyntola@gmail.com> wrote:
>
> It happened in our custom build system. The kernel there doesn't have a
> dependency to the kernel headers and that's pretty much it.
> It's a tiny thing and I already patched our stuff, but I thought I'd let you
> know. Breaching the contaiment makes the build prone to some really funky
> results.

No problem. I queued it up, and I'll let it soak for a while. Given
that it's an old problem and the failure is fairly obscure, I'm
disinclined to send it out before 3.21.

--Andy

>
> cheers,
> Tommi
>
> On Mon, Feb 16, 2015 at 6:29 PM, Andy Lutomirski <luto@amacapital.net>
> wrote:
>>
>> On Mon, Feb 16, 2015 at 6:15 AM, Tommi Kyntola <tommi.kyntola@gmail.com>
>> wrote:
>> >
>> > The build-time tool arch/x86/vdso/vdso2c.c includes <linux/elf.h>,
>> > but cannot find it, unless the build host happens to provide it.
>> > It should be reading the uapi linux/elf.h
>> >
>> > This build regression came along with the vdso2c between
>> > 3.15 and 3.16.
>>
>> I'm curious: what distro or other system are you seeing this problem in?
>>
>> --Andy
>>
>> >
>> > Signed-off-by: Tommi Kyntola <tommi.kyntola@gmail.com>
>> > ---
>> > arch/x86/vdso/Makefile | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
>> > index 5a4affe..745e9fe 100644
>> > --- a/arch/x86/vdso/Makefile
>> > +++ b/arch/x86/vdso/Makefile
>> > @@ -50,7 +50,7 @@ VDSO_LDFLAGS_vdso.lds = -m64
>> > -Wl,-soname=linux-vdso.so.1 \
>> > $(obj)/vdso64.so.dbg: $(src)/vdso.lds $(vobjs) FORCE
>> > $(call if_changed,vdso)
>> >
>> > -HOST_EXTRACFLAGS += -I$(srctree)/tools/include
>> > +HOST_EXTRACFLAGS += -I$(srctree)/tools/include
>> > -I$(srctree)/include/uapi
>> > hostprogs-y += vdso2c
>> >
>> > quiet_cmd_vdso2c = VDSO2C $@
>> > --
>> > 2.1.0
>> >
>>
>>
>>
>> --
>> Andy Lutomirski
>> AMA Capital Management, LLC
>
>

--
Andy Lutomirski
AMA Capital Management, LLC