linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Peter Zijlstra <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: luto@amacapital.net, tglx@linutronix.de, mingo@kernel.org,
	linux-kernel@vger.kernel.org, hpa@zytor.com,
	peterz@infradead.org, acme@redhat.com, sfr@canb.auug.org.au
Subject: [tip:perf/core] tools: Simplify BITS_PER_LONG define
Date: Sat, 16 Jul 2016 13:46:05 -0700	[thread overview]
Message-ID: <tip-e81fcd43723d32e9c9dbb8e8d66f147b5b84256b@git.kernel.org> (raw)
In-Reply-To: <20160715072243.GP30154@twins.programming.kicks-ass.net>

Commit-ID:  e81fcd43723d32e9c9dbb8e8d66f147b5b84256b
Gitweb:     http://git.kernel.org/tip/e81fcd43723d32e9c9dbb8e8d66f147b5b84256b
Author:     Peter Zijlstra <peterz@infradead.org>
AuthorDate: Fri, 15 Jul 2016 12:38:18 -0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 15 Jul 2016 17:26:41 -0300

tools: Simplify BITS_PER_LONG define

Do it using (__CHAR_BIT__ * __SIZEOF_LONG__), simpler, works everywhere,
reduces the complexity by ditching CONFIG_64BIT, that was being
synthesized from yet another set of defines, which proved fragile,
breaking the build on linux-next for no obvious reasons.

Committer Note:

Except on:

gcc version 4.1.2 20080704 (Red Hat 4.1.2-55)

Fallback to __WORDSIZE in that case...

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20160715072243.GP30154@twins.programming.kicks-ass.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/include/asm-generic/bitsperlong.h | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)

diff --git a/tools/include/asm-generic/bitsperlong.h b/tools/include/asm-generic/bitsperlong.h
index cfd661c..45eca51 100644
--- a/tools/include/asm-generic/bitsperlong.h
+++ b/tools/include/asm-generic/bitsperlong.h
@@ -3,31 +3,12 @@
 
 #include <uapi/asm-generic/bitsperlong.h>
 
-/*
- * In the kernel, where this file comes from, we can rely on CONFIG_64BIT,
- * here we have to make amends with what the various compilers provides us
- * to figure out if we're on a 64-bit machine...
- */
 #ifdef __SIZEOF_LONG__
-# if __SIZEOF_LONG__ == 8
-#  define CONFIG_64BIT
-# endif
+#define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF_LONG__)
 #else
-# ifdef __WORDSIZE
-#  if __WORDSIZE == 64
-#   define CONFIG_64BIT
-#  endif
-# else
-#  error Failed to determine BITS_PER_LONG value
-# endif
+#define BITS_PER_LONG __WORDSIZE
 #endif
 
-#ifdef CONFIG_64BIT
-#define BITS_PER_LONG 64
-#else
-#define BITS_PER_LONG 32
-#endif /* CONFIG_64BIT */
-
 #if BITS_PER_LONG != __BITS_PER_LONG
 #error Inconsistent word size. Check asm/bitsperlong.h
 #endif

      parent reply	other threads:[~2016-07-16 20:47 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  7:06 linux-next: build failure after merge of the luto-misc tree Stephen Rothwell
2016-07-15  7:22 ` Peter Zijlstra
2016-07-15  7:31   ` Peter Zijlstra
2016-07-15 15:09     ` Arnaldo Carvalho de Melo
2016-07-15 15:24       ` Arnaldo Carvalho de Melo
2016-07-15 15:29         ` Peter Zijlstra
2016-07-15 15:56           ` Arnaldo Carvalho de Melo
2016-07-15 15:43         ` [PATCH/RFC] " Arnaldo Carvalho de Melo
2016-07-15 15:49           ` Peter Zijlstra
2016-07-15 16:28             ` Arnaldo Carvalho de Melo
2016-07-15 20:26               ` H. Peter Anvin
2016-07-18  5:18           ` Stephen Rothwell
2016-07-18 20:04             ` Andy Lutomirski
2016-07-18 20:36               ` Arnaldo Carvalho de Melo
2016-07-18 22:22                 ` Stephen Rothwell
2016-07-18 23:41                   ` Arnaldo Carvalho de Melo
2016-07-19  0:26                     ` Stephen Rothwell
2016-07-19  0:39                       ` Arnaldo Carvalho de Melo
2016-07-19  3:26                         ` Stephen Rothwell
2016-07-19 12:54                           ` Arnaldo Carvalho de Melo
2016-07-19 17:45                             ` Arnaldo Carvalho de Melo
2016-07-19 23:21                               ` Stephen Rothwell
2016-07-19 23:53                                 ` Stephen Rothwell
2016-07-20  2:52                                   ` Arnaldo Carvalho de Melo
2016-07-20  2:57                                     ` Andy Lutomirski
2016-07-20  3:09                                       ` Arnaldo Carvalho de Melo
2016-07-20  3:18                                         ` Stephen Rothwell
2016-07-20 23:29                                     ` Stephen Rothwell
2016-07-21 13:12                                       ` Arnaldo Carvalho de Melo
2016-07-21 23:23                                         ` Stephen Rothwell
2016-07-22  3:41                                           ` Josh Poimboeuf
2016-07-22 14:37                                             ` Arnaldo Carvalho de Melo
2016-07-22 19:19                                               ` Josh Poimboeuf
2016-07-22 19:36                                                 ` Arnaldo Carvalho de Melo
2016-07-22 19:44                                                   ` Josh Poimboeuf
2016-07-22 19:57                                                     ` Arnaldo Carvalho de Melo
2016-07-23  5:08                                                       ` Stephen Rothwell
2016-07-24 18:40                                                         ` Andy Lutomirski
2016-07-25 12:56                                                         ` Arnaldo Carvalho de Melo
2016-07-25 18:12                                                         ` [tip:perf/core] x86: Make the vdso2c compiler use the host architecture headers tip-bot for Stephen Rothwell
2016-07-25 18:11                                                 ` [tip:perf/core] tools build: Fix objtool build with ARCH=x86_64 tip-bot for Josh Poimboeuf
2016-07-25 18:11                                             ` [tip:perf/core] objtool: Always use host headers tip-bot for Arnaldo Carvalho de Melo
2016-07-16 20:46   ` tip-bot for Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-e81fcd43723d32e9c9dbb8e8d66f147b5b84256b@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).