linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Shuah Khan <shuahkhan@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	shuahkhan@gmail.com, tglx@linutronix.de, hpa@linux.intel.com,
	bp@alien8.de
Subject: [tip:x86/microcode] x86, microcode: microcode_core. c simple_strtoul cleanup
Date: Mon, 7 May 2012 13:49:55 -0700	[thread overview]
Message-ID: <tip-e826abd523913f63eb03b59746ffb16153c53dc4@git.kernel.org> (raw)
In-Reply-To: <1336324264.2897.9.camel@lorien2>

Commit-ID:  e826abd523913f63eb03b59746ffb16153c53dc4
Gitweb:     http://git.kernel.org/tip/e826abd523913f63eb03b59746ffb16153c53dc4
Author:     Shuah Khan <shuahkhan@gmail.com>
AuthorDate: Sun, 6 May 2012 11:11:04 -0600
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Mon, 7 May 2012 11:36:49 -0700

x86, microcode: microcode_core.c simple_strtoul cleanup

Change reload_for_cpu() in kernel/microcode_core.c to call kstrtoul()
instead of calling obsoleted simple_strtoul().

Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
Reviewed-by: Borislav Petkov <bp@alien8.de>
Link: http://lkml.kernel.org/r/1336324264.2897.9.camel@lorien2
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/kernel/microcode_core.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c
index c9bda6d..fbdfc69 100644
--- a/arch/x86/kernel/microcode_core.c
+++ b/arch/x86/kernel/microcode_core.c
@@ -299,12 +299,11 @@ static ssize_t reload_store(struct device *dev,
 {
 	unsigned long val;
 	int cpu = dev->id;
-	int ret = 0;
-	char *end;
+	ssize_t ret = 0;
 
-	val = simple_strtoul(buf, &end, 0);
-	if (end == buf)
-		return -EINVAL;
+	ret = kstrtoul(buf, 0, &val);
+	if (ret)
+		return ret;
 
 	if (val == 1) {
 		get_online_cpus();

      parent reply	other threads:[~2012-05-07 20:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-06 17:11 [PATCH RESEND] x86: kernel/microcode_core.c simple_strtoul cleanup Shuah Khan
2012-05-07 10:49 ` Borislav Petkov
2012-05-07 18:35   ` H. Peter Anvin
2012-05-07 21:16     ` Borislav Petkov
2012-05-08  1:23       ` Henrique de Moraes Holschuh
2012-05-08  4:00         ` Ingo Molnar
2012-05-08 20:42           ` Shuah Khan
2012-05-09  7:00           ` Borislav Petkov
2012-05-07 20:49 ` tip-bot for Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-e826abd523913f63eb03b59746ffb16153c53dc4@git.kernel.org \
    --to=shuahkhan@gmail.com \
    --cc=bp@alien8.de \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).