public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: dsahern@gmail.com, hpa@zytor.com, a.p.zijlstra@chello.nl,
	jolsa@redhat.com, acme@redhat.com, mingo@kernel.org,
	adrian.hunter@intel.com, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, namhyung@kernel.org
Subject: [tip:perf/core] perf tools: Get rid of dso__data_fd() from dso__data_size()
Date: Wed, 27 May 2015 09:48:42 -0700	[thread overview]
Message-ID: <tip-e840238d7c6afcde0f6402aac3a74723ee9c448f@git.kernel.org> (raw)
In-Reply-To: <1432137821-10853-2-git-send-email-namhyung@kernel.org>

Commit-ID:  e840238d7c6afcde0f6402aac3a74723ee9c448f
Gitweb:     http://git.kernel.org/tip/e840238d7c6afcde0f6402aac3a74723ee9c448f
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Thu, 21 May 2015 01:03:40 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 27 May 2015 12:21:44 -0300

perf tools: Get rid of dso__data_fd() from dso__data_size()

It seems that the dso__data_fd() was needed to find a binary type
since open in data_file_size() alone used to fail.

But as it can open the dso fine now, the dso__data_fd() can go away.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1432137821-10853-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/dso.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 516e0c2..e95e850 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -745,12 +745,6 @@ out:
  */
 off_t dso__data_size(struct dso *dso, struct machine *machine)
 {
-	int fd;
-
-	fd = dso__data_fd(dso, machine);
-	if (fd < 0)
-		return fd;
-
 	if (data_file_size(dso, machine))
 		return -1;
 

  parent reply	other threads:[~2015-05-27 16:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 16:03 [PATCH v2 1/3] perf tools: Fix dso__data_read_offset() file opening Namhyung Kim
2015-05-20 16:03 ` [PATCH v2 2/3] perf tools: Get rid of dso__data_fd() from dso__data_size() Namhyung Kim
2015-05-21  7:03   ` Adrian Hunter
2015-05-27 16:48   ` tip-bot for Namhyung Kim [this message]
2015-05-20 16:03 ` [PATCH v2 3/3] perf tools: Add dso__data_get/put_fd() Namhyung Kim
2015-05-21  7:06   ` Adrian Hunter
2015-05-27 16:49   ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-05-21  7:03 ` [PATCH v2 1/3] perf tools: Fix dso__data_read_offset() file opening Adrian Hunter
2015-05-21 14:49   ` Arnaldo Carvalho de Melo
2015-05-27 16:48 ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-e840238d7c6afcde0f6402aac3a74723ee9c448f@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox