From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755469AbbFRMJl (ORCPT ); Thu, 18 Jun 2015 08:09:41 -0400 Received: from terminus.zytor.com ([198.137.202.10]:59748 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753870AbbFRMJf (ORCPT ); Thu, 18 Jun 2015 08:09:35 -0400 Date: Thu, 18 Jun 2015 05:08:17 -0700 From: tip-bot for Russell King Message-ID: Cc: gnurou@gmail.com, tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, lee.jones@linaro.org, rmk+kernel@arm.linux.org.uk, mingo@kernel.org, hpa@zytor.com, linus.walleij@linaro.org, ulli.kroll@googlemail.com Reply-To: gnurou@gmail.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, jason@lakedaemon.net, mingo@kernel.org, hpa@zytor.com, rmk+kernel@arm.linux.org.uk, lee.jones@linaro.org, linus.walleij@linaro.org, ulli.kroll@googlemail.com In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] gpio: gpio-tegra: Fix race in installing chained IRQ handler Git-Commit-ID: e88d251d6a4fb719f9f667a397cf5d755121e551 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: e88d251d6a4fb719f9f667a397cf5d755121e551 Gitweb: http://git.kernel.org/tip/e88d251d6a4fb719f9f667a397cf5d755121e551 Author: Russell King AuthorDate: Tue, 16 Jun 2015 23:06:50 +0100 Committer: Thomas Gleixner CommitDate: Thu, 18 Jun 2015 14:03:08 +0200 gpio: gpio-tegra: Fix race in installing chained IRQ handler Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to irq_set_chained_handler_and_data(). Signed-off-by: Russell King Cc: Alexandre Courbot Cc: Hans Ulli Kroll Cc: Jason Cooper Cc: Lee Jones Cc: Linus Walleij Cc: Thierry Reding Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/E1Z4z0M-0002Sl-Ti@rmk-PC.arm.linux.org.uk Signed-off-by: Thomas Gleixner --- drivers/gpio/gpio-tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 1741981..56dcc8e 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -515,8 +515,8 @@ static int tegra_gpio_probe(struct platform_device *pdev) for (i = 0; i < tegra_gpio_bank_count; i++) { bank = &tegra_gpio_banks[i]; - irq_set_chained_handler(bank->irq, tegra_gpio_irq_handler); - irq_set_handler_data(bank->irq, bank); + irq_set_chained_handler_and_data(bank->irq, + tegra_gpio_irq_handler, bank); for (j = 0; j < 4; j++) spin_lock_init(&bank->lvl_lock[j]);