* [PATCH] x86: Remove unnecessary return from void function
@ 2017-06-23 16:23 Anton Vasilyev
2017-06-24 7:19 ` [tip:x86/cleanups] x86/paravirt: " tip-bot for Anton Vasilyev
2017-10-27 5:42 ` [PATCH] x86: " Juergen Gross
0 siblings, 2 replies; 4+ messages in thread
From: Anton Vasilyev @ 2017-06-23 16:23 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: Anton Vasilyev, Chris Wright, Alok Kataria, Rusty Russell,
Thomas Gleixner, Ingo Molnar, x86, virtualization, linux-kernel,
ldv-project
The patch removes unnecessary return from void function.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
---
arch/x86/include/asm/paravirt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
index 55fa56f..a3dcf89 100644
--- a/arch/x86/include/asm/paravirt.h
+++ b/arch/x86/include/asm/paravirt.h
@@ -118,7 +118,7 @@ static inline u64 paravirt_read_msr(unsigned msr)
static inline void paravirt_write_msr(unsigned msr,
unsigned low, unsigned high)
{
- return PVOP_VCALL3(pv_cpu_ops.write_msr, msr, low, high);
+ PVOP_VCALL3(pv_cpu_ops.write_msr, msr, low, high);
}
static inline u64 paravirt_read_msr_safe(unsigned msr, int *err)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [tip:x86/cleanups] x86/paravirt: Remove unnecessary return from void function
2017-06-23 16:23 [PATCH] x86: Remove unnecessary return from void function Anton Vasilyev
@ 2017-06-24 7:19 ` tip-bot for Anton Vasilyev
2017-10-27 5:42 ` [PATCH] x86: " Juergen Gross
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Anton Vasilyev @ 2017-06-24 7:19 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, hpa, vasilyev, linux-kernel, rusty, torvalds, chrisw,
tglx, akataria, mingo, jeremy
Commit-ID: e8ad8bc403f49f8cb95448acfdeee39b459eded4
Gitweb: http://git.kernel.org/tip/e8ad8bc403f49f8cb95448acfdeee39b459eded4
Author: Anton Vasilyev <vasilyev@ispras.ru>
AuthorDate: Fri, 23 Jun 2017 19:23:13 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 24 Jun 2017 08:53:33 +0200
x86/paravirt: Remove unnecessary return from void function
The patch removes unnecessary return from void function.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Cc: Alok Kataria <akataria@vmware.com>
Cc: Chris Wright <chrisw@sous-sol.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: ldv-project@linuxtesting.org
Cc: virtualization@lists.linux-foundation.org
Link: http://lkml.kernel.org/r/1498234993-1320-1-git-send-email-vasilyev@ispras.ru
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/asm/paravirt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
index 55fa56f..a3dcf89 100644
--- a/arch/x86/include/asm/paravirt.h
+++ b/arch/x86/include/asm/paravirt.h
@@ -118,7 +118,7 @@ static inline u64 paravirt_read_msr(unsigned msr)
static inline void paravirt_write_msr(unsigned msr,
unsigned low, unsigned high)
{
- return PVOP_VCALL3(pv_cpu_ops.write_msr, msr, low, high);
+ PVOP_VCALL3(pv_cpu_ops.write_msr, msr, low, high);
}
static inline u64 paravirt_read_msr_safe(unsigned msr, int *err)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: Remove unnecessary return from void function
2017-06-23 16:23 [PATCH] x86: Remove unnecessary return from void function Anton Vasilyev
2017-06-24 7:19 ` [tip:x86/cleanups] x86/paravirt: " tip-bot for Anton Vasilyev
@ 2017-10-27 5:42 ` Juergen Gross
2017-10-27 8:48 ` Ingo Molnar
1 sibling, 1 reply; 4+ messages in thread
From: Juergen Gross @ 2017-10-27 5:42 UTC (permalink / raw)
To: Anton Vasilyev, Jeremy Fitzhardinge
Cc: ldv-project, x86, Rusty Russell, Alok Kataria, linux-kernel,
virtualization, Chris Wright, Ingo Molnar, Thomas Gleixner
On 23/06/17 18:23, Anton Vasilyev wrote:
> The patch removes unnecessary return from void function.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: Remove unnecessary return from void function
2017-10-27 5:42 ` [PATCH] x86: " Juergen Gross
@ 2017-10-27 8:48 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2017-10-27 8:48 UTC (permalink / raw)
To: Juergen Gross
Cc: Anton Vasilyev, Jeremy Fitzhardinge, ldv-project, x86,
Rusty Russell, Alok Kataria, linux-kernel, virtualization,
Chris Wright, Ingo Molnar, Thomas Gleixner
* Juergen Gross <lists@pfupf.net> wrote:
> On 23/06/17 18:23, Anton Vasilyev wrote:
> > The patch removes unnecessary return from void function.
> >
> > Found by Linux Driver Verification project (linuxtesting.org).
> >
> > Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Cleanup is already upstream, as of v4.13.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-27 8:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-23 16:23 [PATCH] x86: Remove unnecessary return from void function Anton Vasilyev
2017-06-24 7:19 ` [tip:x86/cleanups] x86/paravirt: " tip-bot for Anton Vasilyev
2017-10-27 5:42 ` [PATCH] x86: " Juergen Gross
2017-10-27 8:48 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox