public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH -tip] sched: Use root_task_group_empty only with FAIR_GROUP_SCHED
@ 2009-10-26 19:24 Cyrill Gorcunov
  2009-11-08 13:07 ` [tip:sched/urgent] " tip-bot for Cyrill Gorcunov
  0 siblings, 1 reply; 2+ messages in thread
From: Cyrill Gorcunov @ 2009-10-26 19:24 UTC (permalink / raw)
  To: Ingo Molnar, Peter Zijlstra; +Cc: LKML

Please review. Perhaps there some usage planned in future?

	-- Cyrill
---
root_task_group_empty is used only with
FAIR_GROUP_SCHED so if we use other scheduler
we get

kernel/sched.c:314: warning: ‘root_task_group_empty’ defined but not used

So move CONFIG_FAIR_GROUP_SCHED up that it cover
root_task_group_empty.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
 kernel/sched.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.git/kernel/sched.c
=====================================================================
--- linux-2.6.git.orig/kernel/sched.c
+++ linux-2.6.git/kernel/sched.c
@@ -309,6 +309,8 @@ static DEFINE_PER_CPU_SHARED_ALIGNED(str
  */
 static DEFINE_SPINLOCK(task_group_lock);
 
+#ifdef CONFIG_FAIR_GROUP_SCHED
+
 #ifdef CONFIG_SMP
 static int root_task_group_empty(void)
 {
@@ -316,7 +318,6 @@ static int root_task_group_empty(void)
 }
 #endif
 
-#ifdef CONFIG_FAIR_GROUP_SCHED
 #ifdef CONFIG_USER_SCHED
 # define INIT_TASK_GROUP_LOAD	(2*NICE_0_LOAD)
 #else /* !CONFIG_USER_SCHED */

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-08 13:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-26 19:24 [PATCH -tip] sched: Use root_task_group_empty only with FAIR_GROUP_SCHED Cyrill Gorcunov
2009-11-08 13:07 ` [tip:sched/urgent] " tip-bot for Cyrill Gorcunov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox