From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756163AbdJJLEf (ORCPT ); Tue, 10 Oct 2017 07:04:35 -0400 Received: from terminus.zytor.com ([65.50.211.136]:53697 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756096AbdJJLEc (ORCPT ); Tue, 10 Oct 2017 07:04:32 -0400 Date: Tue, 10 Oct 2017 03:59:54 -0700 From: tip-bot for Brendan Jackman Message-ID: Cc: dietmar.eggemann@arm.com, brendan.jackman@arm.com, torvalds@linux-foundation.org, morten.rasmussen@arm.com, linux-kernel@vger.kernel.org, josef@toxicpanda.com, peterz@infradead.org, tglx@linutronix.de, efault@gmx.de, vincent.guittot@linaro.org, mingo@kernel.org, jbacik@fb.com, hpa@zytor.com Reply-To: torvalds@linux-foundation.org, dietmar.eggemann@arm.com, brendan.jackman@arm.com, morten.rasmussen@arm.com, josef@toxicpanda.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, efault@gmx.de, vincent.guittot@linaro.org, tglx@linutronix.de, jbacik@fb.com, hpa@zytor.com In-Reply-To: <20171005114516.18617-3-brendan.jackman@arm.com> References: <20171005114516.18617-3-brendan.jackman@arm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/fair: Remove unnecessary comparison with -1 Git-Commit-ID: e90381eaecf6d59c60fe396838e0e99789531419 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: e90381eaecf6d59c60fe396838e0e99789531419 Gitweb: https://git.kernel.org/tip/e90381eaecf6d59c60fe396838e0e99789531419 Author: Brendan Jackman AuthorDate: Thu, 5 Oct 2017 12:45:13 +0100 Committer: Ingo Molnar CommitDate: Tue, 10 Oct 2017 11:45:34 +0200 sched/fair: Remove unnecessary comparison with -1 Since commit: 83a0a96a5f26 ("sched/fair: Leverage the idle state info when choosing the "idlest" cpu") find_idlest_group_cpu() (formerly find_idlest_cpu) no longer returns -1, so we can simplify the checking of the return value in find_idlest_cpu(). Signed-off-by: Brendan Jackman Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Josef Bacik Reviewed-by: Vincent Guittot Cc: Dietmar Eggemann Cc: Josef Bacik Cc: Linus Torvalds Cc: Mike Galbraith Cc: Morten Rasmussen Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20171005114516.18617-3-brendan.jackman@arm.com Signed-off-by: Ingo Molnar --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index dd4f253..bdd28fb 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5933,7 +5933,7 @@ static inline int find_idlest_cpu(struct sched_domain *sd, struct task_struct *p } new_cpu = find_idlest_group_cpu(group, p, cpu); - if (new_cpu == -1 || new_cpu == cpu) { + if (new_cpu == cpu) { /* Now try balancing at a lower domain level of cpu */ sd = sd->child; continue;