* [PATCH] perf/x86/intel: constify array lbr_desc and make a function static
@ 2017-06-29 9:14 Colin King
2017-06-30 13:09 ` [tip:perf/core] perf/x86/intel: Constify the 'lbr_desc[]' array " tip-bot for Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-06-29 9:14 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86,
Peter Zijlstra, Dan Carpenter
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
A few minor clean-ups: constify array lbr_desc and make local
function lbr_from_signext_quirk_rd static to fix sparse warning:
"symbol 'lbr_from_signext_quirk_rd' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/events/intel/lbr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c
index f924629836a8..eb261656a320 100644
--- a/arch/x86/events/intel/lbr.c
+++ b/arch/x86/events/intel/lbr.c
@@ -18,7 +18,7 @@ enum {
LBR_FORMAT_MAX_KNOWN = LBR_FORMAT_TIME,
};
-static enum {
+static const enum {
LBR_EIP_FLAGS = 1,
LBR_TSX = 2,
} lbr_desc[LBR_FORMAT_MAX_KNOWN + 1] = {
@@ -287,7 +287,7 @@ inline u64 lbr_from_signext_quirk_wr(u64 val)
/*
* If quirk is needed, ensure sign extension is 61 bits:
*/
-u64 lbr_from_signext_quirk_rd(u64 val)
+static u64 lbr_from_signext_quirk_rd(u64 val)
{
if (static_branch_unlikely(&lbr_from_quirk_key)) {
/*
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perf/core] perf/x86/intel: Constify the 'lbr_desc[]' array and make a function static
2017-06-29 9:14 [PATCH] perf/x86/intel: constify array lbr_desc and make a function static Colin King
@ 2017-06-30 13:09 ` tip-bot for Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Colin Ian King @ 2017-06-30 13:09 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, peterz, linux-kernel, tglx, torvalds, hpa, dan.carpenter,
colin.king
Commit-ID: e91c8d97eac74e603481840d950536bcb62b471b
Gitweb: http://git.kernel.org/tip/e91c8d97eac74e603481840d950536bcb62b471b
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Thu, 29 Jun 2017 10:14:06 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 30 Jun 2017 09:00:56 +0200
perf/x86/intel: Constify the 'lbr_desc[]' array and make a function static
A few minor clean-ups: constify the lbr_desc[] array and make
local function lbr_from_signext_quirk_rd() static to fix a sparse warning:
"symbol 'lbr_from_signext_quirk_rd' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/20170629091406.9870-1-colin.king@canonical.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/events/intel/lbr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c
index f924629..eb26165 100644
--- a/arch/x86/events/intel/lbr.c
+++ b/arch/x86/events/intel/lbr.c
@@ -18,7 +18,7 @@ enum {
LBR_FORMAT_MAX_KNOWN = LBR_FORMAT_TIME,
};
-static enum {
+static const enum {
LBR_EIP_FLAGS = 1,
LBR_TSX = 2,
} lbr_desc[LBR_FORMAT_MAX_KNOWN + 1] = {
@@ -287,7 +287,7 @@ inline u64 lbr_from_signext_quirk_wr(u64 val)
/*
* If quirk is needed, ensure sign extension is 61 bits:
*/
-u64 lbr_from_signext_quirk_rd(u64 val)
+static u64 lbr_from_signext_quirk_rd(u64 val)
{
if (static_branch_unlikely(&lbr_from_quirk_key)) {
/*
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-30 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-29 9:14 [PATCH] perf/x86/intel: constify array lbr_desc and make a function static Colin King
2017-06-30 13:09 ` [tip:perf/core] perf/x86/intel: Constify the 'lbr_desc[]' array " tip-bot for Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox