From: tip-bot for Maurice Ma <maurice.ma@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mjg@redhat.com, hpa@zytor.com,
mingo@redhat.com, rui.zhang@intel.com, matt.fleming@intel.com,
maurice.ma@intel.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/asm] x86, efi: Convert efi_phys_get_time() args to physical addresses
Date: Mon, 5 Dec 2011 05:29:22 -0800 [thread overview]
Message-ID: <tip-e9a9eca517d4cd94e816538efc400257e34bc63e@git.kernel.org> (raw)
In-Reply-To: <1318330333-4617-1-git-send-email-matt@console-pimps.org>
Commit-ID: e9a9eca517d4cd94e816538efc400257e34bc63e
Gitweb: http://git.kernel.org/tip/e9a9eca517d4cd94e816538efc400257e34bc63e
Author: Maurice Ma <maurice.ma@intel.com>
AuthorDate: Tue, 11 Oct 2011 11:52:13 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 5 Dec 2011 12:45:14 +0100
x86, efi: Convert efi_phys_get_time() args to physical addresses
Because callers of efi_phys_get_time() pass virtual stack
addresses as arguments, we need to find their corresponding
physical addresses and when calling GetTime() in physical mode.
Without this patch the following line is printed on boot,
"Oops: efitime: can't read time!"
Signed-off-by: Maurice Ma <maurice.ma@intel.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Matthew Garrett <mjg@redhat.com>
Link: http://lkml.kernel.org/r/1318330333-4617-1-git-send-email-matt@console-pimps.org
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/platform/efi/efi.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 37718f0..d2376eb 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -238,7 +238,8 @@ static efi_status_t __init phys_efi_get_time(efi_time_t *tm,
spin_lock_irqsave(&rtc_lock, flags);
efi_call_phys_prelog();
- status = efi_call_phys2(efi_phys.get_time, tm, tc);
+ status = efi_call_phys2(efi_phys.get_time, virt_to_phys(tm),
+ virt_to_phys(tc));
efi_call_phys_epilog();
spin_unlock_irqrestore(&rtc_lock, flags);
return status;
prev parent reply other threads:[~2011-12-05 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 10:52 [PATCH] x86, efi: Convert efi_phys_get_time() args to physical addresses Matt Fleming
2011-11-07 11:31 ` Matt Fleming
2011-11-07 19:08 ` H. Peter Anvin
2011-11-08 11:27 ` Matt Fleming
2011-11-25 16:38 ` Matt Fleming
2011-12-05 13:29 ` tip-bot for Maurice Ma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-e9a9eca517d4cd94e816538efc400257e34bc63e@git.kernel.org \
--to=maurice.ma@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=mjg@redhat.com \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox