public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL 0/1] perf/urgent fix
@ 2016-05-10 14:26 Arnaldo Carvalho de Melo
  2016-05-10 14:26 ` [PATCH 1/1] perf diff: Fix duplicated output column Arnaldo Carvalho de Melo
  2016-05-10 20:23 ` [GIT PULL 0/1] perf/urgent fix Ingo Molnar
  0 siblings, 2 replies; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-10 14:26 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: linux-kernel, Arnaldo Carvalho de Melo, Jiri Olsa, Namhyung Kim,
	Peter Zijlstra

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 93193230f7b8bd484d1749f4044d1214d521c804:

  perf/core: Change the default paranoia level to 2 (2016-05-10 09:58:51 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160510

for you to fetch changes up to ba07ebe02077751db101ed202bb690f504248575:

  perf diff: Fix duplicated output column (2016-05-10 10:37:05 -0300)

----------------------------------------------------------------
perf/urgent fix:

- Fix duplicated output column in 'perf diff' (Namhyung Kim)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Namhyung Kim (1):
      perf diff: Fix duplicated output column

 tools/perf/util/sort.c | 3 +++
 1 file changed, 3 insertions(+)

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] perf diff: Fix duplicated output column
@ 2016-05-10 12:48 Namhyung Kim
  2016-05-10 20:33 ` [tip:perf/core] " tip-bot for Namhyung Kim
  0 siblings, 1 reply; 6+ messages in thread
From: Namhyung Kim @ 2016-05-10 12:48 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Ingo Molnar, Peter Zijlstra, Jiri Olsa, LKML, stable # 4 . 5

The commit b97511c5bc94 ("perf tools: Add overhead/overhead_children
keys defaults via string") moved initialization of column headers but it
missed to check the sort__mode.  As 'perf diff' doesn't call
perf_hpp__init(), the setup_overhead() also should not be called.

Before:

  # Baseline    Delta  Children  Overhead  Shared Object        Symbol
  # ........  .......  ........  ........  ...................  .......................
  #
      28.48%  -28.47%    28.48%    28.48%  [kernel.vmlinux ]    [k] intel_idle
      11.51%  -11.47%    11.51%    11.51%  libxul.so            [.] 0x0000000001a360f7
       3.49%   -3.49%     3.49%     3.49%  [kernel.vmlinux]     [k] generic_exec_single
       2.91%   -2.89%     2.91%     2.91%  libdbus-1.so.3.8.11  [.] 0x000000000000cdc2
       2.86%   -2.85%     2.86%     2.86%  libxcb.so.1.1.0      [.] 0x000000000000c890
       2.44%   -2.39%     2.44%     2.44%  [kernel.vmlinux]     [k] perf_event_aux_ctx

After:

  # Baseline    Delta  Shared Object        Symbol
  # ........  .......  ...................  .......................
  #
      28.48%  -28.47%  [kernel.vmlinux]     [k] intel_idle
      11.51%  -11.47%  libxul.so            [.] 0x0000000001a360f7
       3.49%   -3.49%  [kernel.vmlinux]     [k] generic_exec_single
       2.91%   -2.89%  libdbus-1.so.3.8.11  [.] 0x000000000000cdc2
       2.86%   -2.85%  libxcb.so.1.1.0      [.] 0x000000000000c890
       2.44%   -2.39%  [kernel.vmlinux]     [k] perf_event_aux_ctx

Cc: stable <stable@vger.kernel.org>  # 4.5
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/util/sort.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 772e2e461ec3..20e69edd5006 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2438,6 +2438,9 @@ static char *prefix_if_not_in(const char *pre, char *str)
 
 static char *setup_overhead(char *keys)
 {
+	if (sort__mode == SORT_MODE__DIFF)
+		return keys;
+
 	keys = prefix_if_not_in("overhead", keys);
 
 	if (symbol_conf.cumulate_callchain)
-- 
2.8.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-11 15:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-10 14:26 [GIT PULL 0/1] perf/urgent fix Arnaldo Carvalho de Melo
2016-05-10 14:26 ` [PATCH 1/1] perf diff: Fix duplicated output column Arnaldo Carvalho de Melo
2016-05-11 12:21   ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-05-11 15:00   ` tip-bot for Namhyung Kim
2016-05-10 20:23 ` [GIT PULL 0/1] perf/urgent fix Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2016-05-10 12:48 [PATCH] perf diff: Fix duplicated output column Namhyung Kim
2016-05-10 20:33 ` [tip:perf/core] " tip-bot for Namhyung Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox