Re: [PATCH] x86/speculation: Clean up various Spectre related details

David Woodhouse
2018-02-11T19:25:27Z

[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]

On Sun, 2018-02-11 at 19:50 +0100, Ingo Molnar wrote:
>
> From 82c2b2f29691143a05181333f387e786646aa28b Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@kernel.org>
> Date: Sat, 10 Feb 2018 11:51:57 +0100
> Subject: [PATCH] x86/speculation: Clean up various Spectre related details
>
> Harmonize all the Spectre messages so that a:
>
>     dmesg | grep -i spectre
>
> ... gives us most Spectre related kernel boot messages.
>
> Also fix a few other details:
>
>  - clarify a comment about firmware speculation control
>
>  - s/KPTI/PTI
>
>  - remove various line-breaks that made the code uglier
>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: David Woodhouse <dwmw@amazon.co.uk>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Ingo Molnar <mingo@kernel.org>

Acked-by: David Woodhouse <dwmw@amazon.co.uk>

with a couple of comments:

-        * If neither SMEP or KPTI are available, there is a risk of
+        * If neither SMEP or PTI are available, there is a risk of

Make that 'neither SMEP nor PTI' while you're at it though please;
that's bugged me a couple of times in passing.

And should these say 'Spectre v2' not just 'Spectre'?

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]