Re: [PATCH] x86/speculation: Clean up various Spectre related details

Ingo Molnar
2018-02-11T19:43:11Z

* David Woodhouse <dwmw2@infradead.org> wrote:

>
>
> On Sun, 2018-02-11 at 19:50 +0100, Ingo Molnar wrote:
> >
> > From 82c2b2f29691143a05181333f387e786646aa28b Mon Sep 17 00:00:00 2001
> > From: Ingo Molnar <mingo@kernel.org>
> > Date: Sat, 10 Feb 2018 11:51:57 +0100
> > Subject: [PATCH] x86/speculation: Clean up various Spectre related details
> >
> > Harmonize all the Spectre messages so that a:
> >
> >     dmesg | grep -i spectre
> >
> > ... gives us most Spectre related kernel boot messages.
> >
> > Also fix a few other details:
> >
> >  - clarify a comment about firmware speculation control
> >
> >  - s/KPTI/PTI
> >
> >  - remove various line-breaks that made the code uglier
> >
> > Cc: Andy Lutomirski <luto@kernel.org>
> > Cc: Arjan van de Ven <arjan@linux.intel.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: David Woodhouse <dwmw@amazon.co.uk>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
>
>
>
> Acked-by: David Woodhouse <dwmw@amazon.co.uk>

Thanks, added.

> with a couple of comments:
>
>
> -        * If neither SMEP or KPTI are available, there is a risk of
> +        * If neither SMEP or PTI are available, there is a risk of
>
> Make that 'neither SMEP nor PTI' while you're at it though please;
> that's bugged me a couple of times in passing.

Ok, fixed that too.

>
> And should these say 'Spectre v2' not just 'Spectre'?

Yeah, you are probably right, but I didn't want to make the messages too specific
- do we really know that this is the end of Spectre-style speculation holes?

Thanks,

Ingo